Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 1148113003: Add pvalenzuela to OWNERS for sync/BUILD.gn (Closed)

Created:
5 years, 7 months ago by pval...(no longer on Chromium)
Modified:
5 years, 7 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add pvalenzuela to OWNERS for sync/BUILD.gn Test targets are defined in BUILD.gn, so it would be convenient to be able to review CLs here. BUG=NONE Committed: https://crrev.com/5c4a1bf3806b82da1c65f0338c29654ef508f6a3 Cr-Commit-Position: refs/heads/master@{#330819}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M sync/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pval...(no longer on Chromium)
5 years, 7 months ago (2015-05-20 18:45:59 UTC) #2
Nicolas Zea
lgtm
5 years, 7 months ago (2015-05-20 21:11:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148113003/1
5 years, 7 months ago (2015-05-20 21:21:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 22:31:07 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 22:32:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c4a1bf3806b82da1c65f0338c29654ef508f6a3
Cr-Commit-Position: refs/heads/master@{#330819}

Powered by Google App Engine
This is Rietveld 408576698