Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 1148083003: Remove uses of const in distiller javascript (Closed)

Created:
5 years, 7 months ago by mdjones
Modified:
5 years, 7 months ago
Reviewers:
nyquist, wychen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove uses of const in distiller javascript Using the 'const' keyword in javascript breaks distiller on iOS. This change removes those instances and replaces them with var. BUG= Committed: https://crrev.com/b0477dae6747caf7b8da9831feef8154f72868e3 Cr-Commit-Position: refs/heads/master@{#330966}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/dom_distiller/core/javascript/dom_distiller_viewer.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
mdjones
This is one option for the fix, the other involves removing the 'use strict' at ...
5 years, 7 months ago (2015-05-20 16:58:13 UTC) #2
wychen
Oops. Forgot about iOS. LGTM.
5 years, 7 months ago (2015-05-20 18:20:59 UTC) #3
mdjones
+nyquist for owner approval.
5 years, 7 months ago (2015-05-20 18:29:52 UTC) #5
nyquist
lgtm
5 years, 7 months ago (2015-05-21 05:42:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148083003/1
5 years, 7 months ago (2015-05-21 15:54:23 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/79005)
5 years, 7 months ago (2015-05-21 18:00:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148083003/1
5 years, 7 months ago (2015-05-21 18:23:44 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 20:30:40 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 20:33:17 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0477dae6747caf7b8da9831feef8154f72868e3
Cr-Commit-Position: refs/heads/master@{#330966}

Powered by Google App Engine
This is Rietveld 408576698