Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1148063003: Check in hello world example so it stays up to date (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
vogelheim
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Check in hello world example so it stays up to date BUG=none R=vogelheim@chromium.org LOG=n Committed: https://crrev.com/3996dc5d6059fe425a1579b4a8f3d247858df63a Cr-Commit-Position: refs/heads/master@{#28542}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -0 lines) Patch
A samples/hello-world.cc View 1 chunk +69 lines, -0 lines 0 comments Download
M samples/samples.gyp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-21 09:08:04 UTC) #1
Yang
On 2015/05/21 09:08:04, jochen wrote: I don't think this is necessary. samples/shell.cc is perfectly fine ...
5 years, 7 months ago (2015-05-21 09:15:58 UTC) #2
jochen (gone - plz use gerrit)
On 2015/05/21 at 09:15:58, yangguo wrote: > On 2015/05/21 09:08:04, jochen wrote: > > I ...
5 years, 7 months ago (2015-05-21 09:18:12 UTC) #3
vogelheim
lgtm Looks good code-wise. I don't really have a strong opinion on Yang's point. It ...
5 years, 7 months ago (2015-05-21 09:29:40 UTC) #4
jochen (gone - plz use gerrit)
Yang said on chat he's ok with landing this
5 years, 7 months ago (2015-05-21 11:11:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148063003/1
5 years, 7 months ago (2015-05-21 11:11:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 11:19:38 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 11:19:50 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3996dc5d6059fe425a1579b4a8f3d247858df63a
Cr-Commit-Position: refs/heads/master@{#28542}

Powered by Google App Engine
This is Rietveld 408576698