Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: src/core/SkStroke.cpp

Issue 1148053003: fix win 8 bot (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkStroke.cpp
diff --git a/src/core/SkStroke.cpp b/src/core/SkStroke.cpp
index b4af9185937c5c4609b6cfa5c132578b4eb5f0ce..eda26d024fae5ad12243a8a3e0df8a78b1094e44 100644
--- a/src/core/SkStroke.cpp
+++ b/src/core/SkStroke.cpp
@@ -1056,7 +1056,9 @@ SkPathStroker::ResultType SkPathStroker::intersectRay(SkQuadConstruct* quadPts,
}
// check to see if the denomerator is teeny relative to the numerator
bool validDivide = SkScalarAbs(numerA) * SK_ScalarNearlyZero < SkScalarAbs(denom);
- SkASSERT(!SkScalarNearlyZero(denom / numerA) == validDivide);
+// the divide check is the same as checking if the scaled denom is nearly zero
+// (commented out because on some platforms the two are not bit-identical)
+// SkASSERT(!SkScalarNearlyZero(denom / numerA) == validDivide);
if (validDivide) {
if (kCtrlPt_RayType == intersectRayType) {
numerA /= denom;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698