Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Issue 1148043002: Remove obsolete Code::optimizable flag. (Closed)

Created:
5 years, 7 months ago by Michael Starzinger
Modified:
5 years, 7 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove obsolete Code::optimizable flag. This flag mostly duplicates SharedFunctionInfo::optimization_disabled and is only queried in places where the original is available. Remove the brittle and error-prone duplication. R=bmeurer@chromium.org Committed: https://crrev.com/794aa072830ac53e9267775956b9bf864e4e0779 Cr-Commit-Position: refs/heads/master@{#28520}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -60 lines) Patch
M src/compiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/log.cc View 5 chunks +11 lines, -9 lines 0 comments Download
M src/objects.h View 2 chunks +1 line, -7 lines 0 comments Download
M src/objects.cc View 5 chunks +4 lines, -12 lines 0 comments Download
M src/objects-inl.h View 4 chunks +1 line, -19 lines 0 comments Download
M src/runtime-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-compiler.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/runtime/runtime-test.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 7 months ago (2015-05-20 13:39:55 UTC) #1
titzer
On 2015/05/20 13:39:55, Michael Starzinger wrote: LGTM
5 years, 7 months ago (2015-05-20 14:13:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148043002/1
5 years, 7 months ago (2015-05-20 14:43:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 14:45:07 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 14:45:23 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/794aa072830ac53e9267775956b9bf864e4e0779
Cr-Commit-Position: refs/heads/master@{#28520}

Powered by Google App Engine
This is Rietveld 408576698