Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1148023002: No need to store ranges in MatchedPropertiesCache. (Closed)

Created:
5 years, 7 months ago by rune
Modified:
5 years, 7 months ago
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

No need to store ranges in MatchedPropertiesCache. There was no need to store the UA/author rule ranges from the MatchResult as those will be equal if the arrays of matched properties are equal. R=esprehn@chromium.org,timloh@chromium.org,dstockwell@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195675

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M Source/core/css/resolver/MatchedPropertiesCache.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/MatchedPropertiesCache.cpp View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rune
5 years, 7 months ago (2015-05-20 12:16:15 UTC) #1
Timothy Loh
On 2015/05/20 12:16:15, rune wrote: lgtm
5 years, 7 months ago (2015-05-21 05:44:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148023002/1
5 years, 7 months ago (2015-05-21 05:46:02 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 05:48:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195675

Powered by Google App Engine
This is Rietveld 408576698