Issue 1148023002: No need to store ranges in MatchedPropertiesCache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1148023002: No need to store ranges in MatchedPropertiesCache. (Closed)

Created:
5 years, 7 months ago by rune

Modified:
5 years, 7 months ago

Reviewers:
dstockwell, Timothy Loh, esprehn

CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

No need to store ranges in MatchedPropertiesCache. There was no need to store the UA/author rule ranges from the MatchResult as those will be equal if the arrays of matched properties are equal. R=esprehn@chromium.org,timloh@chromium.org,dstockwell@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195675

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	Source/core/css/resolver/MatchedPropertiesCache.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	Source/core/css/resolver/MatchedPropertiesCache.cpp	View		2 chunks	+0 lines, -3 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148023002/1

5 years, 7 months ago (2015-05-21 05:46:02 UTC) #4

commit-bot: I haz the power

5 years, 7 months ago (2015-05-21 05:48:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195675