Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1148007: Merge bleeding_edge from version 2.1.3 up to revision 4205... (Closed)

Created:
10 years, 9 months ago by Kasper Lund
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Merge bleeding_edge from version 2.1.3 up to revision 4205 to the partial_snapshots branch. For now, the custom call generator path inside the stub cache code in CallStubCompiler::CompileCallConstant has been disabled because of missing external references for push/pop. TBR=erik.corry@gmail.com Committed: http://code.google.com/p/v8/source/detail?r=4215

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+7321 lines, -1998 lines) Patch
M ChangeLog View 1 chunk +27 lines, -0 lines 0 comments Download
M include/v8.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/SConscript View 4 chunks +5 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/assembler-arm.h View 2 chunks +27 lines, -2 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M src/arm/assembler-arm-inl.h View 2 chunks +25 lines, -6 lines 0 comments Download
M src/arm/codegen-arm.h View 5 chunks +40 lines, -6 lines 0 comments Download
M src/arm/codegen-arm.cc View 6 chunks +100 lines, -13 lines 0 comments Download
M src/arm/constants-arm.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/arm/debug-arm.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 3 chunks +25 lines, -13 lines 0 comments Download
M src/arm/regexp-macro-assembler-arm.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 3 chunks +105 lines, -12 lines 0 comments Download
M src/arm/virtual-frame-arm.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/array.js View 4 chunks +52 lines, -51 lines 0 comments Download
M src/ast.h View 46 chunks +228 lines, -21 lines 0 comments Download
M src/ast.cc View 2 chunks +493 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 5 chunks +1 line, -69 lines 0 comments Download
M src/builtins.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.cc View 15 chunks +121 lines, -40 lines 0 comments Download
A + src/cached-powers.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/checks.h View 2 chunks +22 lines, -0 lines 0 comments Download
A + src/circular-queue.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/circular-queue.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/circular-queue-inl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/codegen.h View 1 chunk +30 lines, -0 lines 0 comments Download
M src/codegen.cc View 2 chunks +16 lines, -32 lines 0 comments Download
M src/compilation-cache.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler.cc View 2 chunks +44 lines, -4 lines 0 comments Download
M src/contexts.h View 3 chunks +0 lines, -8 lines 0 comments Download
M src/conversions.cc View 3 chunks +13 lines, -3 lines 0 comments Download
M src/conversions-inl.h View 2 chunks +9 lines, -2 lines 0 comments Download
M src/counters.h View 1 chunk +1 line, -1 line 0 comments Download
A + src/cpu-profiler.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/cpu-profiler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/cpu-profiler-inl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/data-flow.h View 14 chunks +222 lines, -103 lines 0 comments Download
M src/data-flow.cc View 25 chunks +894 lines, -358 lines 0 comments Download
M src/date.js View 3 chunks +38 lines, -80 lines 0 comments Download
M src/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
A + src/diy-fp.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/diy-fp.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/double.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/factory.h View 3 chunks +4 lines, -2 lines 0 comments Download
M src/factory.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/fast-codegen.cc View 4 chunks +6 lines, -11 lines 0 comments Download
A + src/fast-dtoa.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/fast-dtoa.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/frame-element.h View 2 chunks +13 lines, -2 lines 0 comments Download
M src/frames.cc View 4 chunks +25 lines, -8 lines 0 comments Download
M src/globals.h View 3 chunks +6 lines, -38 lines 0 comments Download
M src/handles.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/handles.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M src/heap.h View 4 chunks +37 lines, -20 lines 0 comments Download
M src/heap.cc View 8 chunks +61 lines, -19 lines 1 comment Download
M src/heap-inl.h View 2 chunks +21 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32.h View 4 chunks +6 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/ia32/codegen-ia32.h View 12 chunks +86 lines, -12 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 75 chunks +767 lines, -246 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 3 chunks +49 lines, -10 lines 0 comments Download
M src/ia32/fast-codegen-ia32.cc View 4 chunks +6 lines, -11 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ia32/ic-ia32.cc View 4 chunks +130 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.h View 4 chunks +20 lines, -4 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 7 chunks +48 lines, -80 lines 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.cc View 3 chunks +19 lines, -4 lines 0 comments Download
M src/ia32/register-allocator-ia32.cc View 2 chunks +57 lines, -5 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 5 chunks +242 lines, -17 lines 0 comments Download
M src/ia32/virtual-frame-ia32.h View 6 chunks +33 lines, -0 lines 0 comments Download
M src/ia32/virtual-frame-ia32.cc View 8 chunks +109 lines, -6 lines 0 comments Download
M src/ic.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/jsregexp.h View 2 chunks +27 lines, -4 lines 0 comments Download
M src/jsregexp.cc View 5 chunks +120 lines, -94 lines 0 comments Download
M src/liveedit.h View 1 chunk +1 line, -1 line 0 comments Download
M src/liveedit.cc View 4 chunks +263 lines, -9 lines 0 comments Download
M src/liveedit-debugger.js View 1 chunk +5 lines, -0 lines 0 comments Download
M src/log.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/log-utils.h View 1 chunk +1 line, -1 line 0 comments Download
M src/log-utils.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/macros.py View 1 chunk +3 lines, -3 lines 0 comments Download
M src/math.js View 4 chunks +7 lines, -6 lines 0 comments Download
M src/messages.js View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/codegen-mips.h View 4 chunks +10 lines, -9 lines 0 comments Download
M src/mips/codegen-mips.cc View 4 chunks +17 lines, -1 line 0 comments Download
M src/mips/codegen-mips-inl.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/mips/simulator-mips.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/mips/virtual-frame-mips.h View 3 chunks +4 lines, -2 lines 0 comments Download
M src/objects.h View 5 chunks +17 lines, -8 lines 1 comment Download
M src/objects.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 3 chunks +28 lines, -2 lines 0 comments Download
M src/parser.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/parser.cc View 19 chunks +93 lines, -8 lines 0 comments Download
M src/platform.h View 2 chunks +5 lines, -1 line 0 comments Download
A + src/powers-ten.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/profile-generator.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/profile-generator.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/profile-generator-inl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/regexp.js View 8 chunks +86 lines, -6 lines 0 comments Download
M src/register-allocator.h View 3 chunks +16 lines, -1 line 0 comments Download
M src/rewriter.cc View 14 chunks +51 lines, -3 lines 0 comments Download
M src/runtime.h View 7 chunks +8 lines, -6 lines 0 comments Download
M src/runtime.cc View 30 chunks +776 lines, -101 lines 1 comment Download
M src/scopes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/serialize.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/splay-tree.h View 2 chunks +12 lines, -0 lines 0 comments Download
M src/splay-tree-inl.h View 4 chunks +54 lines, -20 lines 0 comments Download
M src/string.js View 10 chunks +141 lines, -56 lines 0 comments Download
M src/stub-cache.h View 4 chunks +22 lines, -3 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/top.h View 3 chunks +3 lines, -5 lines 0 comments Download
M src/top.cc View 5 chunks +24 lines, -35 lines 0 comments Download
M src/utils.h View 4 chunks +39 lines, -2 lines 0 comments Download
M src/v8.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/v8-counters.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/v8threads.h View 2 chunks +15 lines, -0 lines 0 comments Download
M src/v8threads.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/variables.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/virtual-frame.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/virtual-frame-inl.h View 1 chunk +11 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.h View 2 chunks +5 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.cc View 7 chunks +38 lines, -0 lines 0 comments Download
M src/x64/codegen-x64.h View 10 chunks +91 lines, -14 lines 0 comments Download
M src/x64/codegen-x64.cc View 12 chunks +349 lines, -157 lines 0 comments Download
M src/x64/disasm-x64.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/x64/ic-x64.cc View 5 chunks +118 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 2 chunks +14 lines, -2 lines 0 comments Download
M src/x64/register-allocator-x64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 3 chunks +119 lines, -12 lines 0 comments Download
M src/x64/virtual-frame-x64.h View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/SConscript View 2 chunks +7 lines, -0 lines 0 comments Download
A + test/cctest/gay-shortest.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/cctest/gay-shortest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 4 chunks +8 lines, -0 lines 0 comments Download
A + test/cctest/test-circular-queue.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +9 lines, -8 lines 0 comments Download
A + test/cctest/test-cpu-profiler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 chunk +36 lines, -34 lines 0 comments Download
A + test/cctest/test-diy-fp.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/cctest/test-double.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/cctest/test-fast-dtoa.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M test/cctest/test-log.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 1 chunk +5 lines, -3 lines 0 comments Download
A + test/cctest/test-profile-generator.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +0 lines, -1 line 0 comments Download
A + test/mjsunit/abs.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/array-pop.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/array-push.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/compiler/loopcount.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/debug-liveedit-patch-positions.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/debug-liveedit-patch-positions-replace.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M test/mjsunit/fuzz-natives.js View 2 chunks +11 lines, -3 lines 0 comments Download
M test/mjsunit/math-round.js View 1 chunk +49 lines, -0 lines 0 comments Download
A + test/mjsunit/regexp-cache-replace.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regexp-compile.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-641.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-643.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-646.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/generate-ten-powers.scm View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/gyp/v8.gyp View 4 chunks +14 lines, -0 lines 0 comments Download
M tools/v8.xcodeproj/project.pbxproj View 7 chunks +30 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_base.vcproj View 3 chunks +36 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_base_arm.vcproj View 3 chunks +36 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_base_x64.vcproj View 3 chunks +36 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_cctest.vcproj View 3 chunks +12 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_cctest_arm.vcproj View 3 chunks +12 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_cctest_x64.vcproj View 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kasper Lund
10 years, 9 months ago (2010-03-23 08:34:56 UTC) #1
Erik Corry
10 years, 9 months ago (2010-03-23 10:12:44 UTC) #2
LGTM

http://codereview.chromium.org/1148007/diff/1/42
File src/heap.cc (right):

http://codereview.chromium.org/1148007/diff/1/42#newcode117
src/heap.cc:117: int Heap::unflattended_strings_length_ = 0;
That's not even a word!

http://codereview.chromium.org/1148007/diff/1/91
File src/objects.h (right):

http://codereview.chromium.org/1148007/diff/1/91#newcode3162
src/objects.h:3162: // Currently it either has FunctionTemplateInfo to make
benefit the API
Somehow, attempting to fix the Borat quotes isn't helping :-)

http://codereview.chromium.org/1148007/diff/1/85
File src/runtime.cc (right):

http://codereview.chromium.org/1148007/diff/1/85#newcode1252
src/runtime.cc:1252: CustomCallGenerator generator = NULL) {
This should be an external reference (note for later).

Powered by Google App Engine
This is Rietveld 408576698