Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1147973002: [turbofan] Add streaming operator for opcodes to ease debugging. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add streaming operator for opcodes to ease debugging. R=mstarzinger@chromium.org Committed: https://crrev.com/d3c1a7fbfca4ab96f26661bb41749401b52429e4 Cr-Commit-Position: refs/heads/master@{#28505}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/compiler/opcodes.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/opcodes.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 7 months ago (2015-05-20 09:47:55 UTC) #1
Benedikt Meurer
Hey Michi, This way the CHECK_*/DCHECK_*s on the opcodes will tell you wants wrong without ...
5 years, 7 months ago (2015-05-20 09:48:45 UTC) #2
Michael Starzinger
LGTM.
5 years, 7 months ago (2015-05-20 09:50:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147973002/1
5 years, 7 months ago (2015-05-20 09:50:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 10:13:06 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 10:13:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3c1a7fbfca4ab96f26661bb41749401b52429e4
Cr-Commit-Position: refs/heads/master@{#28505}

Powered by Google App Engine
This is Rietveld 408576698