Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1147933002: Switch prefs.js to Object.observe now that observe-js is no longer a dep. (Closed)

Created:
5 years, 7 months ago by Jeremy Klein
Modified:
5 years, 7 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch prefs.js to Object.observe now that observe-js is no longer a dep. BUG= Committed: https://crrev.com/1c2d4fcd417d9f063dbb9d77811f66c00b637f8b Cr-Commit-Position: refs/heads/master@{#330797}

Patch Set 1 #

Patch Set 2 : fix docs #

Total comments: 4

Patch Set 3 : michaels comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -20 lines) Patch
M chrome/browser/resources/settings/prefs/prefs.js View 1 2 2 chunks +12 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jeremy Klein
5 years, 7 months ago (2015-05-20 01:37:34 UTC) #2
michaelpg
lgtm w/ comments https://codereview.chromium.org/1147933002/diff/20001/chrome/browser/resources/settings/prefs/prefs.js File chrome/browser/resources/settings/prefs/prefs.js (right): https://codereview.chromium.org/1147933002/diff/20001/chrome/browser/resources/settings/prefs/prefs.js#newcode71 chrome/browser/resources/settings/prefs/prefs.js:71: * @param {boolean} shouldObserve Whether to ...
5 years, 7 months ago (2015-05-20 03:25:40 UTC) #3
Jeremy Klein
https://codereview.chromium.org/1147933002/diff/20001/chrome/browser/resources/settings/prefs/prefs.js File chrome/browser/resources/settings/prefs/prefs.js (right): https://codereview.chromium.org/1147933002/diff/20001/chrome/browser/resources/settings/prefs/prefs.js#newcode71 chrome/browser/resources/settings/prefs/prefs.js:71: * @param {boolean} shouldObserve Whether to add an ObjectObserver ...
5 years, 7 months ago (2015-05-20 18:06:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147933002/40001
5 years, 7 months ago (2015-05-20 18:07:00 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-20 20:53:15 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 20:53:59 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/1c2d4fcd417d9f063dbb9d77811f66c00b637f8b
Cr-Commit-Position: refs/heads/master@{#330797}

Powered by Google App Engine
This is Rietveld 408576698