Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 1147923002: Fix another -Wsign-compare bug with GCC 4.9.2. (Closed)

Created:
5 years, 7 months ago by paul.l...
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix another -Wsign-compare bug with GCC 4.9.2. BUG= Committed: https://crrev.com/dd0f469da3901ed6dabf84232fa41bb2fe59137b Cr-Commit-Position: refs/heads/master@{#28498}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/api.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
paul.l...
PTAL, another one like https://codereview.chromium.org/1128043002, from today's https://codereview.chromium.org/1113233002
5 years, 7 months ago (2015-05-20 01:58:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147923002/1
5 years, 7 months ago (2015-05-20 06:37:22 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-20 06:37:24 UTC) #6
Sven Panne
lgtm
5 years, 7 months ago (2015-05-20 06:38:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147923002/1
5 years, 7 months ago (2015-05-20 06:38:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 07:13:15 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 07:13:23 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd0f469da3901ed6dabf84232fa41bb2fe59137b
Cr-Commit-Position: refs/heads/master@{#28498}

Powered by Google App Engine
This is Rietveld 408576698