Prepare GetProperty(Attributes)WithInterceptor to support elements

Prepare GetProperty(Attributes)WithInterceptor to support elements

BUG=v8:4137
LOG=n

Committed: https://crrev.com/a40e85d668919a2afab69355e1d3bad6bbfbaaf0
Cr-Commit-Position: refs/heads/master@{#28564}

[Toon Verwaest, 2015-05-19 17:09:01]

Patchset #1 (id:1) has been deleted

[Toon Verwaest, 2015-05-19 17:09:20]

verwaest@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Toon Verwaest, 2015-05-19 17:09:20]

PTAL

[Jakob Kummerow, 2015-05-20 09:24:15]

LGTM with comments.

https://codereview.chromium.org/1147863002/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1147863002/diff/20001/src/objects.cc#newcode4362
src/objects.cc:4362: AssertNoContextChange ncc(it->isolate());
nit: it->isolate() is used often enough that I'd pull it out to "Isolate*
isolate = it->isolate();" to make all the places using it look a bit cleaner. Up
to you though.

https://codereview.chromium.org/1147863002/diff/20001/src/objects.cc#newcode4396
src/objects.cc:4396: // TODO(verwaest): Use GetPropertyWithInterceptor?
Sounds good. Or pull out the common core into a standalone helper. Can be a
follow-up CL though.

https://codereview.chromium.org/1147863002/diff/20001/src/objects.cc#newcode4408
src/objects.cc:4408: if (name->IsSymbol() &&
!interceptor->can_intercept_symbols()) {
I don't think this can happen; you've ruled this out above in line 4367/4368.

[Toon Verwaest, 2015-05-21 13:53:21]

Addressed comments

[Toon Verwaest, 2015-05-21 14:47:27]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-05-21 14:47:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1147863002/#ps60001
(title: "Addressed comments")

[commit-bot: I haz the power, 2015-05-21 14:47:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1147863002/60001

[commit-bot: I haz the power, 2015-05-21 15:32:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-21 15:32:12]

Try jobs failed on following builders:
  v8_linux_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/5023)

[Toon Verwaest, 2015-05-21 16:42:41]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-05-21 16:42:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1147863002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2015-05-21 16:43:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1147863002/80001

[Toon Verwaest, 2015-05-21 16:46:30]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-05-21 16:46:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1147863002/#ps100001
(title: "Fix")

[commit-bot: I haz the power, 2015-05-21 16:46:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1147863002/100001

[commit-bot: I haz the power, 2015-05-21 17:24:35]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2015-05-21 17:24:53]

Patchset 5 (id:??) landed as
https://crrev.com/a40e85d668919a2afab69355e1d3bad6bbfbaaf0
Cr-Commit-Position: refs/heads/master@{#28564}