Properly handle circular references among constants in the task model.

pkg/analyzer/test/src/task/test_support.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.src.task.test_support;
 
 import 'package:analyzer/src/generated/engine.dart' hide AnalysisTask;
 import 'package:analyzer/src/generated/java_engine.dart';
 import 'package:analyzer/task/model.dart';
 
@@ skipping 14 matching lines @@
   /**
    * The results whose values are to be provided as outputs from this task.
    */
   List<ResultDescriptor> results;
 
   /**
    * The next value that is to be used for a result.
    */
   int value;
 
+  @override
+  final bool handlesDependencyCycles;
+
   TestAnalysisTask(AnalysisContext context, AnalysisTarget target,
-      {this.descriptor, this.exception, this.results, this.value: 1})
+      {this.descriptor, this.exception, this.results, this.value: 1,
+      this.handlesDependencyCycles: false})

[scheglov, 2015/05/19 19:25:42]

Please keep these parameters sorted by name.

[Paul Berry, 2015/05/19 19:36:11]

Done.

       : super(context, target);
 
   @override
   String get description => 'Test task';
 
   @override
   internalPerform() {
     if (exception != null) {
       caughtException = exception;
     } else if (results != null) {
       for (ResultDescriptor result in results) {
         outputs[result] = value++;
       }
     } else if (descriptor != null) {
       for (ResultDescriptor result in descriptor.results) {
         outputs[result] = value++;
       }
     }
   }
 }