Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Issue 1147813003: Files.app: Tell users that the remaining space is 0 bytes when Drive usage is over quota. (Closed)

Created:
5 years, 7 months ago by fukino
Modified:
5 years, 7 months ago
Reviewers:
kinaba
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Tell users that the remaining space is 0 bytes when Drive usage is over quota. BUG=459871 TEST=manually confirm that the remaining space shown on the bannar and the gear menu is 0 bytes when Drive usage is over quota. Committed: https://crrev.com/ccd065321b95c47e03d267a142778c5cbd14c636 Cr-Commit-Position: refs/heads/master@{#330490}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
fukino
kinaba@, could you take a look? Thanks!
5 years, 7 months ago (2015-05-19 05:24:04 UTC) #2
kinaba
lgtm
5 years, 7 months ago (2015-05-19 06:02:27 UTC) #3
fukino
On 2015/05/19 06:02:27, kinaba wrote: > lgtm Thanks!
5 years, 7 months ago (2015-05-19 07:09:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147813003/1
5 years, 7 months ago (2015-05-19 07:10:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 07:44:02 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 07:44:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ccd065321b95c47e03d267a142778c5cbd14c636
Cr-Commit-Position: refs/heads/master@{#330490}

Powered by Google App Engine
This is Rietveld 408576698