Issue 11478049: Disable SSL session cache to fix issue with SecureSocket connections.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11478049: Disable SSL session cache to fix issue with SecureSocket connections. (Closed)

Created:
8 years ago by Bill Hesse

Modified:
8 years ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Disable SSL session cache to fix issue with SecureSocket connections. BUG=dart:7208 TEST=standalone/io/secure_session_resume_test.dart Committed: https://code.google.com/p/dart/source/detail?r=15904

Patch Set 2 : Address comments, speed up test. #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -4 lines)			Patch
M	runtime/bin/secure_socket.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
A +	tests/standalone/io/secure_session_resume_test.dart	View	1	3 chunks	+19 lines, -3 lines	0 comments	Download
M	tests/standalone/standalone.status	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

LGTM, but let's make the test as fast as we can. https://codereview.chromium.org/11478049/diff/1/tests/standalone/io/secure_session_resume_test.dart File tests/standalone/io/secure_session_resume_test.dart (right): ...

8 years ago (2012-12-10 11:28:50 UTC) #2

Bill Hesse

8 years ago (2012-12-10 13:13:20 UTC) #3

Made test run faster, added FAIL to status of bad_certificate_test on Windows.

https://codereview.chromium.org/11478049/diff/1/tests/standalone/io/secure_se...
File tests/standalone/io/secure_session_resume_test.dart (right):

https://codereview.chromium.org/11478049/diff/1/tests/standalone/io/secure_se...
tests/standalone/io/secure_session_resume_test.dart:126: int
delay_between_connections = 200;  // Milliseconds.
On 2012/12/10 11:28:50, Mads Ager wrote:
> Does this fail with a smaller timeout as well? Can you delay only one and get
> the issue? We should make this test as fast as we can. Maybe we should make a
> specific test for this issue instead of putting it into the basic test?

The timeout needs to be at least 200 ms, and more if we only do one delayed one.
 I can change it to 400ms, and only do one delayed.  So that is only 500ms for
the entire test.

Expand Messages | Collapse Messages

Issue 11478049: Disable SSL session cache to fix issue with SecureSocket connections. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comments, speed up test. #

Messages