sdk/lib/_internal/compiler/implementation/ssa/optimize.dart - Issue 11478022: Implement is-checks with typedefs for callable objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

Issue 11478022: Implement is-checks with typedefs for callable objects. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/ssa/nodes.dart ('K') | « sdk/lib/_internal/compiler/implementation/ssa/nodes.dart ('k') | tests/co19/co19-dart2dart.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart b/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

index 036d1ac4b4de5a5b01413c5e9f163ad103e1e833..1eb93d10d26f12b3c5875b12da2d89ba1977d6e4 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

@@ -511,8 +511,10 @@ class SsaConstantFolder extends HBaseVisitor implements OptimizationPhase {

HInstruction visitIs(HIs node) {

DartType type = node.typeExpression;

Element element = type.element;

- if (identical(element.kind, ElementKind.TYPE_VARIABLE)) {

+ if (element.isTypeVariable()) {

compiler.unimplemented("visitIs for type variables");

+ } if (element.isTypedef()) {

+ return node;

}

HType expressionType = types[node.expression];