sdk/lib/_internal/compiler/implementation/ssa/builder.dart - Issue 11478022: Implement is-checks with typedefs for callable objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 11478022: Implement is-checks with typedefs for callable objects. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/codegen.dart » ('j') | sdk/lib/_internal/compiler/implementation/ssa/nodes.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

index fcbc105b9e001e8c6e6289483e07419bb857087a..e7f7d6e4efd26ab02961e68c62a1ea6edc291ce2 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

@@ -2740,8 +2740,8 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {

}

HInstruction instruction;

- if (RuntimeTypeInformation.hasTypeArguments(type) ||

- type.element.isTypeVariable()) {

+ if ((RuntimeTypeInformation.hasTypeArguments(type) &&

+ type.element.isClass()) || type.element.isTypeVariable()) {

floitsch 2012/12/07 15:30:15 this looks too much like && (... || ...) please br

karlklose 2012/12/11 08:40:05 The change was actually not necessary anymore. Rem

HInstruction typeInfo = getRuntimeTypeInfo(expression);

// TODO(karlklose): make isSubtype a HInstruction to enable

// optimizations?