Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: runtime/vm/exceptions.cc

Issue 11478012: Provide a mechanism for dumping of heap profiles on predefined events. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: cosmetic changes Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/heap.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/exceptions.cc
diff --git a/runtime/vm/exceptions.cc b/runtime/vm/exceptions.cc
index f56af6a37e6969a6809bd57defe43c81c5754ac3..432a376ba275ef2ba92249f1fa6104616836db9d 100644
--- a/runtime/vm/exceptions.cc
+++ b/runtime/vm/exceptions.cc
@@ -9,6 +9,7 @@
#include "vm/debugger.h"
#include "vm/flags.h"
#include "vm/object.h"
+#include "vm/object_store.h"
#include "vm/stack_frame.h"
#include "vm/stub_code.h"
#include "vm/symbols.h"
@@ -16,7 +17,10 @@
namespace dart {
DEFINE_FLAG(bool, print_stacktrace_at_throw, false,
- "Prints a stack trace everytime a throw occurs.");
+ "Prints a stack trace everytime a throw occurs.");
+DEFINE_FLAG(bool, heap_profile_out_of_memory, false,
+ "Writes a heap profile on unhandled out-of-memory exceptions.");
+DECLARE_FLAG(bool, heap_profile_out_of_memory);
const char* Exceptions::kCastErrorDstName = "type cast";
@@ -190,6 +194,12 @@ static void ThrowExceptionHelper(const Instance& incoming_exception,
exception,
stacktrace);
} else {
+ if (FLAG_heap_profile_out_of_memory) {
+ Isolate* isolate = Isolate::Current();
+ if (exception.raw() == isolate->object_store()->out_of_memory()) {
+ isolate->heap()->ProfileToFile("out-of-memory");
+ }
+ }
// No dart exception handler found in this invocation sequence,
// so we create an unhandled exception object and return to the
// invocation stub so that it returns this unhandled exception
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698