Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: utils/tests/pub/pub_lish_test.dart

Issue 11478004: Stop working around issue 7044. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/pub_lish_test.dart
diff --git a/utils/tests/pub/pub_lish_test.dart b/utils/tests/pub/pub_lish_test.dart
index b2b165555187083beb1b63a96c6a346ec5a49a3c..1bfa3d6cfb69a2c347d2016380c7159ad693903d 100644
--- a/utils/tests/pub/pub_lish_test.dart
+++ b/utils/tests/pub/pub_lish_test.dart
@@ -284,18 +284,11 @@ main() {
handleUploadForm(server);
server.handle('POST', '/upload', (request, response) {
- // TODO(rnystrom): HTTP requires that you don't start sending a response
- // until the request has been completely sent, but dart:io doesn't
- // ensure that (#7044). Workaround it by manually consuming the entire
- // input stream before we start responding. If we don't do this, curl
- // will choke on this on Mac and Windows.
- return consumeInputStream(request.inputStream).transform((_) {
- response.statusCode = 400;
- response.headers.contentType = new ContentType('application', 'xml');
- response.outputStream.writeString('<Error><Message>Your request sucked.'
- '</Message></Error>');
- response.outputStream.close();
- });
+ response.statusCode = 400;
+ response.headers.contentType = new ContentType('application', 'xml');
+ response.outputStream.writeString('<Error><Message>Your request sucked.'
+ '</Message></Error>');
+ response.outputStream.close();
});
// TODO(nweiz): This should use the server's error message once the client
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698