Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1147793003: Revert of do not hardcode -I/usr/include32 when cross-compiling (Closed)

Created:
5 years, 7 months ago by hans
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of do not hardcode -I/usr/include32 when cross-compiling (patchset #1 id:1 of https://codereview.chromium.org/1132853010/) Reason for revert: Looks like this broke some builds, where 'use_sysroot' isn't defined. See http://crbug.com/489783. Sounds like sbc has an alternative solution here: https://codereview.chromium.org/1142793003/ Original issue's description: > do not hardcode -I/usr/include32 when cross-compiling > > When we cross-compile, we do not want any /usr/include paths as that will > conflict with our own system headers. Disable the hardcoded path when we > have an active sysroot. > > BUG=chromium:488360 > > Committed: https://crrev.com/58b42a0c48127c60baad7ea79ea0e5576c6e1d0b > Cr-Commit-Position: refs/heads/master@{#330514} TBR=jochen@chromium.org,cjhopman@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org,scottmg@chromium.org,thakis@chromium.org,vapier@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=488360, 489783 Committed: https://crrev.com/bcfef56a5d3c703d5e62d8984533a3b241f3ff0c Cr-Commit-Position: refs/heads/master@{#330656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
hans
Created Revert of do not hardcode -I/usr/include32 when cross-compiling
5 years, 7 months ago (2015-05-19 23:31:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147793003/1
5 years, 7 months ago (2015-05-20 00:22:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 00:28:34 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 00:30:03 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bcfef56a5d3c703d5e62d8984533a3b241f3ff0c
Cr-Commit-Position: refs/heads/master@{#330656}

Powered by Google App Engine
This is Rietveld 408576698