Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1147753002: Fixup Wallet sync. (Closed)

Created:
5 years, 7 months ago by please use gerrit instead
Modified:
5 years, 7 months ago
Reviewers:
maniscalco
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, albertb+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixup Wallet sync. 1) Select the correct preference name for synced data type. 2) Set the correct field name when converting Wallet specifics to dictionary. BUG=481595 Committed: https://crrev.com/fb3f20a21b926221b4e5a43d3430013134e6c887 Cr-Commit-Position: refs/heads/master@{#330441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M components/sync_driver/sync_prefs.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M sync/protocol/proto_value_conversions.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
please use gerrit instead
Nick, PTAL. The bugs fixed in this patch are not causing any issues, but best ...
5 years, 7 months ago (2015-05-18 21:26:03 UTC) #2
maniscalco
lgtm
5 years, 7 months ago (2015-05-18 21:39:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147753002/1
5 years, 7 months ago (2015-05-18 21:41:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 22:16:42 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:44:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb3f20a21b926221b4e5a43d3430013134e6c887
Cr-Commit-Position: refs/heads/master@{#330441}

Powered by Google App Engine
This is Rietveld 408576698