Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 1147743004: Adding ecmascript simd tests. (Closed)

Created:
5 years, 7 months ago by bradnelson
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Adding ecmascript simd tests. Relying on the polyfill for now. BUG=v8:4124 LOG=N R=bbudge@chromium.org,machenbach@chromium.org TEST=trybots Committed: https://crrev.com/8dfec46e38853ab7503662eb17f8e5475663ec2b Cr-Commit-Position: refs/heads/master@{#28470}

Patch Set 1 #

Total comments: 9

Patch Set 2 : fix #

Patch Set 3 : drop extra code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -0 lines) Patch
M .gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
A test/simdjs/harness-adapt.js View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
A test/simdjs/harness-finish.js View 1 1 chunk +26 lines, -0 lines 0 comments Download
A test/simdjs/simdjs.status View 1 1 chunk +19 lines, -0 lines 0 comments Download
A test/simdjs/testcfg.py View 1 1 chunk +101 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
bradnelson
5 years, 7 months ago (2015-05-19 02:52:54 UTC) #1
Michael Achenbach
https://codereview.chromium.org/1147743004/diff/1/test/simdjs/harness-adapt.js File test/simdjs/harness-adapt.js (right): https://codereview.chromium.org/1147743004/diff/1/test/simdjs/harness-adapt.js#newcode47 test/simdjs/harness-adapt.js:47: _oldLoad('test/simdjs/data/src/benchmarks/' + filename); Did you test that? Not sure ...
5 years, 7 months ago (2015-05-19 07:17:48 UTC) #2
bbudge
https://codereview.chromium.org/1147743004/diff/1/test/simdjs/harness-adapt.js File test/simdjs/harness-adapt.js (right): https://codereview.chromium.org/1147743004/diff/1/test/simdjs/harness-adapt.js#newcode29 test/simdjs/harness-adapt.js:29: "use strict"; ?
5 years, 7 months ago (2015-05-19 08:36:02 UTC) #3
Michael Achenbach
https://codereview.chromium.org/1147743004/diff/1/test/simdjs/harness-adapt.js File test/simdjs/harness-adapt.js (right): https://codereview.chromium.org/1147743004/diff/1/test/simdjs/harness-adapt.js#newcode47 test/simdjs/harness-adapt.js:47: _oldLoad('test/simdjs/data/src/benchmarks/' + filename); On 2015/05/19 07:17:48, Michael Achenbach wrote: ...
5 years, 7 months ago (2015-05-19 09:34:48 UTC) #4
bradn
https://codereview.chromium.org/1147743004/diff/1/test/simdjs/harness-adapt.js File test/simdjs/harness-adapt.js (right): https://codereview.chromium.org/1147743004/diff/1/test/simdjs/harness-adapt.js#newcode29 test/simdjs/harness-adapt.js:29: On 2015/05/19 08:36:01, bbudge (OOO week of 5-11) wrote: ...
5 years, 7 months ago (2015-05-19 09:37:53 UTC) #6
Michael Achenbach
lgtm
5 years, 7 months ago (2015-05-19 09:40:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147743004/40001
5 years, 7 months ago (2015-05-19 09:48:48 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-19 10:14:54 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 10:15:14 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8dfec46e38853ab7503662eb17f8e5475663ec2b
Cr-Commit-Position: refs/heads/master@{#28470}

Powered by Google App Engine
This is Rietveld 408576698