Issue 114773004: Provide last resort for fCapHeight in SkFontHost_FreeType::onGetAdvancedTypefaceMetrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 114773004: Provide last resort for fCapHeight in SkFontHost_FreeType::onGetAdvancedTypefaceMetrics. (Closed)

Created:
7 years ago by bungeman-skia

Modified:
7 years ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com, vandebo (ex-Chrome)

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Provide last resort for fCapHeight in SkFontHost_FreeType::onGetAdvancedTypefaceMetrics. This was a pre-existing issue, but r12689 uncovered it in more cases. Since there was no last resort, fonts without a cap height used uninitialized data as their cap height here. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=12779

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	src/ports/SkFontHost_FreeType.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bungeman-skia

7 years ago (2013-12-19 19:34:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r12779 (presubmit successful).

Expand Messages | Collapse Messages