Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1147703002: [iOS] Upstream crash loop detection utilities (Closed)

Created:
5 years, 7 months ago by sdefresne
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Upstream crash loop detection utilities BUG=429756 Committed: https://crrev.com/1a289251ed7ac5b2a41d90f2ace9724405401101 Cr-Commit-Position: refs/heads/master@{#330361}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address noyau comments #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -2 lines) Patch
A ios/chrome/browser/crash_loop_detection_util.h View 1 1 chunk +30 lines, -0 lines 0 comments Download
A ios/chrome/browser/crash_loop_detection_util.mm View 1 chunk +41 lines, -0 lines 0 comments Download
A ios/chrome/browser/crash_loop_detection_util_unittest.mm View 1 chunk +42 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M ios/chrome/ios_chrome_tests.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sdefresne
PTAL
5 years, 7 months ago (2015-05-18 13:37:20 UTC) #2
noyau (Ping after 24h)
lgtm with nit https://codereview.chromium.org/1147703002/diff/1/ios/chrome/browser/crash_loop_detection_util.h File ios/chrome/browser/crash_loop_detection_util.h (right): https://codereview.chromium.org/1147703002/diff/1/ios/chrome/browser/crash_loop_detection_util.h#newcode17 ios/chrome/browser/crash_loop_detection_util.h:17: // If flush_immediately is true, the ...
5 years, 7 months ago (2015-05-18 13:50:40 UTC) #3
sdefresne
Thank you for the review. https://codereview.chromium.org/1147703002/diff/1/ios/chrome/browser/crash_loop_detection_util.h File ios/chrome/browser/crash_loop_detection_util.h (right): https://codereview.chromium.org/1147703002/diff/1/ios/chrome/browser/crash_loop_detection_util.h#newcode17 ios/chrome/browser/crash_loop_detection_util.h:17: // If flush_immediately is ...
5 years, 7 months ago (2015-05-18 14:42:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147703002/40001
5 years, 7 months ago (2015-05-18 14:43:30 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-18 15:00:29 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 15:01:24 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/1a289251ed7ac5b2a41d90f2ace9724405401101
Cr-Commit-Position: refs/heads/master@{#330361}

Powered by Google App Engine
This is Rietveld 408576698