Fix in process PPAPI decryption.

webkit/plugins/ppapi/content_decryptor_delegate.cc

Index: webkit/plugins/ppapi/content_decryptor_delegate.cc
diff --git a/webkit/plugins/ppapi/content_decryptor_delegate.cc b/webkit/plugins/ppapi/content_decryptor_delegate.cc
index be79e12f3fa0cbcbe04897256a5c145d758f197b..db71162ae38e1d5b310401006d437beebab4d927 100644
--- a/webkit/plugins/ppapi/content_decryptor_delegate.cc
+++ b/webkit/plugins/ppapi/content_decryptor_delegate.cc
@@ -1004,6 +1004,10 @@ bool ContentDecryptorDelegate::MakeMediaBufferResource(
     }
   }
 
+  // Take an extra reference on the resource to ensure that the reference count
+  // does not reach zero when the PPAPI glue releases its reference.
+  PpapiGlobals::Get()->GetResourceTracker()->AddRefResource(media_resource);

[dmichael (off chromium), 2012/12/06 19:30:09]

If you need an extra reference, then don't use the PassRef() constructor above.
Add a comment about how you need to pass a reference to the plugin, or
something. (See comment below)

[Tom Finegan, 2012/12/06 22:59:02]

I'm trying to make an optimization work: The decryptor delegate now reuses
PPB_Buffer_Dev resources, so removing PassRef() here won't help. This only
happens when the resource is created, and we always need an extra ref.

But, I think you point out the underlying cause of this problem in the next
comment...

+
   EnterResourceNoLock<PPB_Buffer_API> enter(media_resource, true);
   if (enter.failed()) {
     media_resource.Release();