[Launcher per display] Removed Shell::status_area_widget(), system_tray()

[Launcher per display] Removed Shell::status_area_widget(), system_tray()
 HasPrimaryStatusArea/GetPrimarySystemTray for login screen
 which will have only one tray/status area on primary

BUG=145978
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172169

[oshima, 2012-12-07 23:28:15]

steven can you take a look at the change below?

sky please review everything.

https://codereview.chromium.org/11476033/diff/9002/ash/root_window_controller.cc
File ash/root_window_controller.cc (right):

https://codereview.chromium.org/11476033/diff/9002/ash/root_window_controller...
ash/root_window_controller.cc:233: user::LoginStatus login =
Shell::GetInstance()->tray_delegate() ?
steven, I didn't fully understand why this had to check
status_area_widget instead of tray_delegate. Is this ok?

[sky, 2012-12-07 23:53:00]

LGTM with the following changes.

https://codereview.chromium.org/11476033/diff/9002/ash/root_window_controller.cc
File ash/root_window_controller.cc (right):

https://codereview.chromium.org/11476033/diff/9002/ash/root_window_controller...
ash/root_window_controller.cc:458: CHECK(status_area);
DCHECK. CHECK is typically only used when trying to isolate a crash or for
security reasons.

https://codereview.chromium.org/11476033/diff/9002/ash/root_window_controller.h
File ash/root_window_controller.h (right):

https://codereview.chromium.org/11476033/diff/9002/ash/root_window_controller...
ash/root_window_controller.h:66: // Returns a RootWnidowController of the
window's root window.
RootWindowController

https://codereview.chromium.org/11476033/diff/9002/ash/root_window_controller...
ash/root_window_controller.h:91: // Calling this on the root window that doesn't
have a launcher will
Calling -> calling

[oshima, 2012-12-08 00:00:45]

https://codereview.chromium.org/11476033/diff/9002/ash/root_window_controller.cc
File ash/root_window_controller.cc (right):

https://codereview.chromium.org/11476033/diff/9002/ash/root_window_controller...
ash/root_window_controller.cc:458: CHECK(status_area);
On 2012/12/07 23:53:00, sky wrote:
> DCHECK. CHECK is typically only used when trying to isolate a crash or for
> security reasons.

Done.

I believe steven added this for some troubleshooting.
Steven, please speak up if you want to keep (or remove) this.

https://codereview.chromium.org/11476033/diff/9002/ash/root_window_controller.h
File ash/root_window_controller.h (right):

https://codereview.chromium.org/11476033/diff/9002/ash/root_window_controller...
ash/root_window_controller.h:66: // Returns a RootWnidowController of the
window's root window.
On 2012/12/07 23:53:00, sky wrote:
> RootWindowController

Done.

https://codereview.chromium.org/11476033/diff/9002/ash/root_window_controller...
ash/root_window_controller.h:91: // Calling this on the root window that doesn't
have a launcher will
On 2012/12/07 23:53:00, sky wrote:
> Calling -> calling

Done.

[oshima, 2012-12-10 20:16:57]

On 2012/12/08 01:44:58, oshima wrote:

steven, could you please review the change in root_window_controller.cc:223?

[stevenjb, 2012-12-10 20:29:38]

lgtm

https://codereview.chromium.org/11476033/diff/10003/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/11476033/diff/10003/ash/shell.cc#newcode706
ash/shell.cc:706: }  else {
nit: extra ' ' before else

[oshima, 2012-12-10 20:33:12]

https://codereview.chromium.org/11476033/diff/10003/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/11476033/diff/10003/ash/shell.cc#newcode706
ash/shell.cc:706: }  else {
On 2012/12/10 20:29:38, stevenjb (chromium) wrote:
> nit: extra ' ' before else

Done.

[commit-bot: I haz the power, 2012-12-10 20:33:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/11476033/16001

[commit-bot: I haz the power, 2012-12-10 22:57:11]

Change committed as 172169