Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Unified Diff: utils/pub/validator/name.dart

Issue 11476030: Properly parse library names on Windows in pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/validator/name.dart
diff --git a/utils/pub/validator/name.dart b/utils/pub/validator/name.dart
index 3a37e31dd9f10e14e9f064893608e539d84e5e65..570f8b8302bce638dfe2f83b8ffbffb2a39fe525 100644
--- a/utils/pub/validator/name.dart
+++ b/utils/pub/validator/name.dart
@@ -33,7 +33,7 @@ class NameValidator extends Validator {
for (var file in files) {
if (file.contains("/src/")) continue;
if (new Path(file).extension != 'dart') continue;
- var libName = new Path(file).filenameWithoutExtension;
+ var libName = new Path(basename(file)).filenameWithoutExtension;
_checkName(libName, 'The name of "$file", "$libName",');
}
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698