ozone: Add atomic initialization path

ozone: Add atomic initialization path

Atomic is only selected if the kernel indicates support (SetCapability
succeeds), the platform wants to use it and DRM is new enough to support it (define)

Also fixes up the atomic page flip path, callbacks weren't being handled properly

Committed: https://crrev.com/effd312ed38f2c3306f0c8e97d22dc6cacf61da8
Cr-Commit-Position: refs/heads/master@{#330614}

[achaulk, 2015-05-15 18:12:19]

achaulk@chromium.org changed reviewers:
+ dnicoara@chromium.org, spang@chromium.org

[dnicoara, 2015-05-19 17:13:14]

https://codereview.chromium.org/1147553003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/chrome_restart_request.cc (right):

https://codereview.chromium.org/1147553003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/chrome_restart_request.cc:171:
::switches::kOzoneUseAtomicDrm,
This is a platform specific flag. I know that this adds limitations but, I don't
think we want to start adding platform specific flags outside the platform.

[achaulk, 2015-05-19 17:15:44]

https://codereview.chromium.org/1147553003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/chrome_restart_request.cc (right):

https://codereview.chromium.org/1147553003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/chrome_restart_request.cc:171:
::switches::kOzoneUseAtomicDrm,
On 2015/05/19 17:13:14, dnicoara wrote:
> This is a platform specific flag. I know that this adds limitations but, I
don't
> think we want to start adding platform specific flags outside the platform.

The other option is to add a new platform drm_atomic

[dnicoara, 2015-05-19 17:21:58]

https://codereview.chromium.org/1147553003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/chrome_restart_request.cc (right):

https://codereview.chromium.org/1147553003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/chrome_restart_request.cc:171:
::switches::kOzoneUseAtomicDrm,
On 2015/05/19 17:15:44, achaulk wrote:
> On 2015/05/19 17:13:14, dnicoara wrote:
> > This is a platform specific flag. I know that this adds limitations but, I
> don't
> > think we want to start adding platform specific flags outside the platform.
> 
> The other option is to add a new platform drm_atomic

Well, we could just make it a compile time flag. I know that having it as a flag
will make it easier to switch between the two during initial
development/debugging, but other than that we expect to just move towards the
atomic API and even deprecate the old path if possible.

[achaulk, 2015-05-19 17:27:36]

https://codereview.chromium.org/1147553003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/chrome_restart_request.cc (right):

https://codereview.chromium.org/1147553003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/chrome_restart_request.cc:171:
::switches::kOzoneUseAtomicDrm,
On 2015/05/19 17:21:58, dnicoara wrote:
> On 2015/05/19 17:15:44, achaulk wrote:
> > On 2015/05/19 17:13:14, dnicoara wrote:
> > > This is a platform specific flag. I know that this adds limitations but, I
> > don't
> > > think we want to start adding platform specific flags outside the
platform.
> > 
> > The other option is to add a new platform drm_atomic
> 
> Well, we could just make it a compile time flag. I know that having it as a
flag
> will make it easier to switch between the two during initial
> development/debugging, but other than that we expect to just move towards the
> atomic API and even deprecate the old path if possible.

Yeah, at which point we rip out the flag. The goal is to make it so you don't
need a custom build to use this path, which means compile time isn't necessarily
enough

[dnicoara, 2015-05-19 17:54:06]

https://codereview.chromium.org/1147553003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/chrome_restart_request.cc (right):

https://codereview.chromium.org/1147553003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/chrome_restart_request.cc:171:
::switches::kOzoneUseAtomicDrm,
On 2015/05/19 17:27:36, achaulk wrote:
> On 2015/05/19 17:21:58, dnicoara wrote:
> > On 2015/05/19 17:15:44, achaulk wrote:
> > > On 2015/05/19 17:13:14, dnicoara wrote:
> > > > This is a platform specific flag. I know that this adds limitations but,
I
> > > don't
> > > > think we want to start adding platform specific flags outside the
> platform.
> > > 
> > > The other option is to add a new platform drm_atomic
> > 
> > Well, we could just make it a compile time flag. I know that having it as a
> flag
> > will make it easier to switch between the two during initial
> > development/debugging, but other than that we expect to just move towards
the
> > atomic API and even deprecate the old path if possible.
> 
> Yeah, at which point we rip out the flag. The goal is to make it so you don't
> need a custom build to use this path, which means compile time isn't
necessarily
> enough

I still don't see much value outside your development workflow, but I do see
this creating precedent on sprinkling platform specific flags outside the
platform code.

Lets proceed with relying on USE_DRM_ATOMIC and drmSetClientCap() to enable
atomic.

[achaulk, 2015-05-19 18:52:55]

removed flag for now

[dnicoara, 2015-05-19 19:36:21]

lgtm

https://codereview.chromium.org/1147553003/diff/40001/ui/ozone/platform/drm/g...
File ui/ozone/platform/drm/gpu/hardware_display_plane_atomic.h (right):

https://codereview.chromium.org/1147553003/diff/40001/ui/ozone/platform/drm/g...
ui/ozone/platform/drm/gpu/hardware_display_plane_atomic.h:31: void
set_crtc(CrtcController* crtc) { crtc_ = crtc; }
As a separate change, could you go over
HardwareDisplayPlane{List,Atomic,Legacy,Manager} and refactor the logic to share
more code and provide a more consistent design? For example, the legacy path
uses a PageFlipInfo struct owned inside HDPList while the atomic path relies on
inheritance.

[achaulk, 2015-05-19 21:13:41]

The CQ bit was checked by achaulk@chromium.org

[commit-bot: I haz the power, 2015-05-19 21:14:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1147553003/40001

[commit-bot: I haz the power, 2015-05-19 21:39:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-19 21:41:42]

Patchset 3 (id:??) landed as
https://crrev.com/effd312ed38f2c3306f0c8e97d22dc6cacf61da8
Cr-Commit-Position: refs/heads/master@{#330614}