Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1147533004: [Telemetry] Updates record_wpr to use argparse. (Closed)

Created:
5 years, 7 months ago by nednguyen
Modified:
5 years, 7 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@MoveRecorWpr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Updates record_wpr to use argparse. This patch updates record_wpr to use argparse for: + record_wpr <XYZ> will make <XYZ> a benchmark name to be recorded. + record_wpr --user-story <XYZ> will make <XYZ> a user story (page set) name to be recorded + record_wpr --list-benchmarks & --list-user-stories will list out benchmark names & user stories (page sets) names. This is useful since the current record_wpr target name matching is a bit funky due to discover.DiscoverClasses's keys naming scheme. Subsequent patches will update it so that the target matching name for benchmarks matched the convention in benchmark_runner.py & matching name for user stories use the user stories's class name. Since more code refactoring are required, I haven't added unittest for these new changes yet. TEST=" git cl patch this. ./perf/record_wpr --help ./perf/record_wpr --list-user-stories ./perf/record_wpr --list-bechmarks " BUG=470865 Committed: https://crrev.com/0272cae5fa1c70ec751fd5dd19b31a368babc0c8 Cr-Commit-Position: refs/heads/master@{#330206}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : user-story -> story #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -19 lines) Patch
M tools/telemetry/telemetry/record_wpr.py View 1 5 chunks +71 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
nednguyen
5 years, 7 months ago (2015-05-15 18:53:48 UTC) #3
sullivan
lgtm https://codereview.chromium.org/1147533004/diff/20001/tools/telemetry/telemetry/record_wpr.py File tools/telemetry/telemetry/record_wpr.py (right): https://codereview.chromium.org/1147533004/diff/20001/tools/telemetry/telemetry/record_wpr.py#newcode102 tools/telemetry/telemetry/record_wpr.py:102: output_stream.write('Available page sets\' names:\n') Why "page sets" and ...
5 years, 7 months ago (2015-05-15 19:19:42 UTC) #4
nednguyen
https://codereview.chromium.org/1147533004/diff/20001/tools/telemetry/telemetry/record_wpr.py File tools/telemetry/telemetry/record_wpr.py (right): https://codereview.chromium.org/1147533004/diff/20001/tools/telemetry/telemetry/record_wpr.py#newcode102 tools/telemetry/telemetry/record_wpr.py:102: output_stream.write('Available page sets\' names:\n') On 2015/05/15 19:19:41, sullivan wrote: ...
5 years, 7 months ago (2015-05-15 19:58:16 UTC) #5
nednguyen
On 2015/05/15 19:58:16, nednguyen (slow review) wrote: > https://codereview.chromium.org/1147533004/diff/20001/tools/telemetry/telemetry/record_wpr.py > File tools/telemetry/telemetry/record_wpr.py (right): > > ...
5 years, 7 months ago (2015-05-15 20:11:31 UTC) #6
sullivan
lgtm
5 years, 7 months ago (2015-05-15 20:13:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147533004/40001
5 years, 7 months ago (2015-05-15 20:25:40 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 7 months ago (2015-05-15 21:52:40 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:27:57 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0272cae5fa1c70ec751fd5dd19b31a368babc0c8
Cr-Commit-Position: refs/heads/master@{#330206}

Powered by Google App Engine
This is Rietveld 408576698