Add connectivity check using system stack.

Add connectivity check using system stack.

There is already functionality to check whether Chrome can reach the Internet
by using the Chrome network stack.

This adds the functionality to use the Android system network stack to do the
same check, which is helpful for feedback reports in case something is awry
with the Chrome network stack.

The Chrome network stack support was added in:
https://codereview.chromium.org/1127983002/

BUG=386395
Committed: https://crrev.com/716c586dd24f35e64733d2639e732a3e336a9bbd
Cr-Commit-Position: refs/heads/master@{#330121}

[nyquist, 2015-05-15 15:51:14]

nyquist@chromium.org changed reviewers:
+ yfriedman@chromium.org

[nyquist, 2015-05-15 15:51:14]

yfriedman: PTAL

this follows up on https://codereview.chromium.org/1127983002/ by adding support
for using the android network stack. Using this stack is helpful for feedback
reports in case there is something awry with Chrome's stack.

[nyquist, 2015-05-15 15:51:49]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[Yaron, 2015-05-15 15:57:50]

https://codereview.chromium.org/1147533002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityChecker.java
(right):

https://codereview.chromium.org/1147533002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityChecker.java:53:
* This method must be called on the main thread.
If it must be called on UI thread why are you posting to UI thread?

https://codereview.chromium.org/1147533002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityChecker.java:100:
}.execute();
can you use THREAD_POOL_EXECUTOR to not block the serial one?

[commit-bot: I haz the power, 2015-05-15 16:01:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1147533002/1

[nyquist, 2015-05-15 16:32:19]

yfriedman: PTAL

https://codereview.chromium.org/1147533002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityChecker.java
(right):

https://codereview.chromium.org/1147533002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityChecker.java:53:
* This method must be called on the main thread.
On 2015/05/15 15:57:50, Yaron wrote:
> If it must be called on UI thread why are you posting to UI thread?

Because I believe that as a caller of this API, it is awkward to get the
callback before your method call has completed.

https://codereview.chromium.org/1147533002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityChecker.java:100:
}.execute();
On 2015/05/15 15:57:50, Yaron wrote:
> can you use THREAD_POOL_EXECUTOR to not block the serial one?

Sorry. Yes! Done.

[Yaron, 2015-05-15 17:06:04]

The CQ bit was checked by yfriedman@chromium.org

[Yaron, 2015-05-15 17:06:04]

lgtm

https://codereview.chromium.org/1147533002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityChecker.java
(right):

https://codereview.chromium.org/1147533002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityChecker.java:53:
* This method must be called on the main thread.
On 2015/05/15 16:32:18, nyquist wrote:
> On 2015/05/15 15:57:50, Yaron wrote:
> > If it must be called on UI thread why are you posting to UI thread?
> 
> Because I believe that as a caller of this API, it is awkward to get the
> callback before your method call has completed.

Fair enough

[commit-bot: I haz the power, 2015-05-15 17:06:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1147533002/20001

[commit-bot: I haz the power, 2015-05-15 17:32:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-15 17:33:45]

Patchset 2 (id:??) landed as
https://crrev.com/716c586dd24f35e64733d2639e732a3e336a9bbd
Cr-Commit-Position: refs/heads/master@{#330121}