Aggressively discard tiles on OS X to see if it improves

Aggressively discard tiles on OS X to see if it improves
stability

BUG=


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172775

[ccameron, 2012-12-08 00:49:43]

This will pull down memory usage (especially on long pages), on OS X by
discarding anything that is >2000 pixels away from being visible. This will
result in worse fling performance.

Do we have a bug for "OS X is having too many GPU crashes", or should I just
throw this in the "big memory footprint" bug?

Also, should I not commit this until we have some histograms first?

[vangelis, 2012-12-08 01:07:02]

lgtm after addressing the feedback.

https://codereview.chromium.org/11475050/diff/1/content/common/gpu/gpu_memory...
File content/common/gpu/gpu_memory_manager.cc (right):

https://codereview.chromium.org/11475050/diff/1/content/common/gpu/gpu_memory...
content/common/gpu/gpu_memory_manager.cc:477: // Expermient to determine if
aggressively discarding tiles on OS X
typo: experiment

nit: Ideally you'll want to merge this with the one above:

#if defined(OS_MACOSX)
  allocation = nicetohave
#else
  allocation = alloweverything
#endif

[ccameron, 2012-12-11 01:16:59]

Thanks.

kbr, can I have an OWNER review?

[ccameron, 2012-12-11 20:45:25]

Ping, need an OWNER review.

[Ken Russell (switch to Gerrit), 2012-12-11 22:36:09]

Sorry for delay; buried under email. LGTM

[ccameron, 2012-12-11 22:39:15]

Thanks!

[commit-bot: I haz the power, 2012-12-11 22:41:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/11475050/3002

[commit-bot: I haz the power, 2012-12-11 23:06:08]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-12-12 23:17:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/11475050/9003

[commit-bot: I haz the power, 2012-12-13 02:09:05]

Change committed as 172775