Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs

Issue 11475048: [NaCl SDK Addin] Fix detection of PNaCl toolchain. (Closed) Base URL: http://nativeclient-sdk.googlecode.com/svn/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/SDKUtilities.cs ('K') | « visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/SDKUtilities.cs ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs
diff --git a/visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs b/visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs
index e63c766f338022914d75bc1cab75ad03f6e283a4..bf00ee00d8504af6cf0d1a67d5d9e5d17bed0919 100644
--- a/visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs
+++ b/visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs
@@ -153,10 +153,8 @@ namespace UnitTests
[TestMethod]
public void CheckPNaClCompile()
{
- int revision;
string root = System.Environment.GetEnvironmentVariable("NACL_SDK_ROOT");
- SDKUtilities.GetSDKVersion(root, out revision);
- if (revision < SDKUtilities.MinPNaCLSDKVersion)
+ if (!SDKUtilities.SupportsPNaCl(root))
{
Assert.Inconclusive();
}
« visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/SDKUtilities.cs ('K') | « visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/SDKUtilities.cs ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698