Issue 11475048: [NaCl SDK Addin] Fix detection of PNaCl toolchain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11475048: [NaCl SDK Addin] Fix detection of PNaCl toolchain. (Closed)

Created:
8 years ago by Sam Clegg

Modified:
8 years ago

Reviewers:
noelallen1, binji

CC:
native-client-reviews_googlegroups.com

Base URL:
http://nativeclient-sdk.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK Addin] Fix detection of PNaCl toolchain. The check was incorrectly looking at the revsion alone which can be higher for older version (e.g it can be higher on 23 than it is on 24). BUG= Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1472

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix long long #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -10 lines)			Patch
M	visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/SDKUtilities.cs	View	1	3 chunks	+18 lines, -3 lines	0 comments	Download
M	visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

noelallen1

8 years ago (2012-12-08 00:50:23 UTC) #1

One wrap issue, otherwise LGTM

https://codereview.chromium.org/11475048/diff/1/visual_studio/NativeClientVSA...
File visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/SDKUtilities.cs
(right):

https://codereview.chromium.org/11475048/diff/1/visual_studio/NativeClientVSA...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/SDKUtilities.cs:73: if
(version == SDKUtilities.MinPNaCLSDKVersion && revision >=
SDKUtilities.MinPNaCLSDKRevision)
wrap

Expand Messages | Collapse Messages