Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: runtime/vm/intermediate_language_x64.cc

Issue 11475042: Add code comments to slow paths. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 1589 matching lines...) Expand 10 before | Expand all | Expand 10 after
1600 return summary; 1600 return summary;
1601 } 1601 }
1602 1602
1603 1603
1604 class CheckStackOverflowSlowPath : public SlowPathCode { 1604 class CheckStackOverflowSlowPath : public SlowPathCode {
1605 public: 1605 public:
1606 explicit CheckStackOverflowSlowPath(CheckStackOverflowInstr* instruction) 1606 explicit CheckStackOverflowSlowPath(CheckStackOverflowInstr* instruction)
1607 : instruction_(instruction) { } 1607 : instruction_(instruction) { }
1608 1608
1609 virtual void EmitNativeCode(FlowGraphCompiler* compiler) { 1609 virtual void EmitNativeCode(FlowGraphCompiler* compiler) {
1610 __ Comment("CheckStackOverflowSlowPath");
1610 __ Bind(entry_label()); 1611 __ Bind(entry_label());
1611 compiler->SaveLiveRegisters(instruction_->locs()); 1612 compiler->SaveLiveRegisters(instruction_->locs());
1612 compiler->GenerateCallRuntime(instruction_->token_pos(), 1613 compiler->GenerateCallRuntime(instruction_->token_pos(),
1613 kStackOverflowRuntimeEntry, 1614 kStackOverflowRuntimeEntry,
1614 instruction_->locs()); 1615 instruction_->locs());
1615 compiler->RestoreLiveRegisters(instruction_->locs()); 1616 compiler->RestoreLiveRegisters(instruction_->locs());
1616 __ jmp(exit_label()); 1617 __ jmp(exit_label());
1617 } 1618 }
1618 1619
1619 private: 1620 private:
(...skipping 341 matching lines...) Expand 10 before | Expand all | Expand 10 after
1961 return summary; 1962 return summary;
1962 } 1963 }
1963 1964
1964 1965
1965 class BoxDoubleSlowPath : public SlowPathCode { 1966 class BoxDoubleSlowPath : public SlowPathCode {
1966 public: 1967 public:
1967 explicit BoxDoubleSlowPath(BoxDoubleInstr* instruction) 1968 explicit BoxDoubleSlowPath(BoxDoubleInstr* instruction)
1968 : instruction_(instruction) { } 1969 : instruction_(instruction) { }
1969 1970
1970 virtual void EmitNativeCode(FlowGraphCompiler* compiler) { 1971 virtual void EmitNativeCode(FlowGraphCompiler* compiler) {
1972 __ Comment("BoxDoubleSlowPath");
1971 __ Bind(entry_label()); 1973 __ Bind(entry_label());
1972 const Class& double_class = compiler->double_class(); 1974 const Class& double_class = compiler->double_class();
1973 const Code& stub = 1975 const Code& stub =
1974 Code::Handle(StubCode::GetAllocationStubForClass(double_class)); 1976 Code::Handle(StubCode::GetAllocationStubForClass(double_class));
1975 const ExternalLabel label(double_class.ToCString(), stub.EntryPoint()); 1977 const ExternalLabel label(double_class.ToCString(), stub.EntryPoint());
1976 1978
1977 LocationSummary* locs = instruction_->locs(); 1979 LocationSummary* locs = instruction_->locs();
1978 locs->live_registers()->Remove(locs->out()); 1980 locs->live_registers()->Remove(locs->out());
1979 1981
1980 compiler->SaveLiveRegisters(locs); 1982 compiler->SaveLiveRegisters(locs);
(...skipping 453 matching lines...) Expand 10 before | Expand all | Expand 10 after
2434 2436
2435 void ShiftMintOpInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 2437 void ShiftMintOpInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
2436 UNIMPLEMENTED(); 2438 UNIMPLEMENTED();
2437 } 2439 }
2438 2440
2439 } // namespace dart 2441 } // namespace dart
2440 2442
2441 #undef __ 2443 #undef __
2442 2444
2443 #endif // defined TARGET_ARCH_X64 2445 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698