Flush out potential leaks of Failure objects

src/objects-inl.h

Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index 9ff35efbcf90aac117d2f1001fed87d705a8741e..abf99862719c61d0b37a96067ef858e986e8613e 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -1064,7 +1064,9 @@ Failure* Failure::Construct(Type type, intptr_t value) {
   uintptr_t info =
       (static_cast<uintptr_t>(value) << kFailureTypeTagSize) | type;
   ASSERT(((info << kFailureTagSize) >> kFailureTagSize) == info);
-  return reinterpret_cast<Failure*>((info << kFailureTagSize) | kFailureTag);
+  static const int kFailureMagicPattern = 0x0BAD0000;

[Michael Starzinger, 2012/12/10 11:51:24]

Either we intend to revert this again later, in which case we should bu a TODO
comment here. Or we intend to leave it in, in which case a short comment that
this is only to "recognize failures in crash reports" might be helpful.

+  return reinterpret_cast<Failure*>(
+      (info << kFailureTagSize) | kFailureTag | kFailureMagicPattern);
 }