Issue 11475027: Flush out potential leaks of Failure objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11475027: Flush out potential leaks of Failure objects (Closed)

Created:
8 years ago by Jakob Kummerow

Modified:
8 years ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Flush out potential leaks of Failure objects Committed: http://code.google.com/p/v8/source/detail?r=13181

Patch Set 2 : added comment #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
M	src/heap.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/objects.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/objects-inl.h	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/11475027/diff/1/src/objects-inl.h File src/objects-inl.h (right): https://codereview.chromium.org/11475027/diff/1/src/objects-inl.h#newcode1067 src/objects-inl.h:1067: static const int kFailureMagicPattern = 0x0BAD0000; Either we ...

8 years ago (2012-12-10 11:51:24 UTC) #2

Good point, added a comment.

Landed.

Expand Messages | Collapse Messages

Issue 11475027: Flush out potential leaks of Failure objects (Closed)

Description

Patch Set 1 #

Patch Set 2 : added comment #

Messages