Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 11475012: Return an unhandled exception error on an OOM or other errors while (Closed)

Created:
8 years ago by siva
Modified:
8 years ago
Reviewers:
Tom Ball
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Return an unhandled exception error on an OOM or other errors while reading a message. This ensures that we never call FindExceptionHelper with no dart invocation frames. Committed: https://code.google.com/p/dart/source/detail?r=15833

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -41 lines) Patch
M vm/exceptions.cc View 2 chunks +7 lines, -22 lines 0 comments Download
M vm/isolate.cc View 1 4 chunks +21 lines, -11 lines 0 comments Download
M vm/snapshot.h View 3 chunks +3 lines, -0 lines 0 comments Download
M vm/snapshot.cc View 3 chunks +26 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
siva
8 years ago (2012-12-07 00:03:47 UTC) #1
Tom Ball
8 years ago (2012-12-07 00:22:10 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698