Chromium Code Reviews

Issue 1147493002: Reland "MIPS: Add float instructions and test coverage, part one" (Closed)

Created:
5 years, 7 months ago by Djordje.Pesic
Modified:
5 years, 7 months ago
Reviewers:
Djordje.Pesic, paul.l..., balazs.kilvady, dusmil.imgtec, akos.palfi.imgtec
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "MIPS: Add float instructions and test coverage, part one" Implement assembler, disassembler tests for all instructions for mips32 and mips64. Additionally, add missing single precision float instructions for r2 and r6 architecture variants in assembler, simulator and disassembler with corresponding tests. Committed: https://crrev.com/0f93a456ec8b17eeb47154842c6a888cebd53bf7 Cr-Commit-Position: refs/heads/master@{#28472}

Patch Set 1 #

Patch Set 2 : Bug fixed #

Unified diffs Side-by-side diffs Stats (+4213 lines, -351 lines)
M src/mips/assembler-mips.h View 2 chunks +20 lines, -1 line 0 comments
M src/mips/assembler-mips.cc View 14 chunks +158 lines, -48 lines 0 comments
M src/mips/constants-mips.h View 4 chunks +19 lines, -4 lines 0 comments
M src/mips/disasm-mips.cc View 3 chunks +28 lines, -0 lines 0 comments
M src/mips/simulator-mips.h View 1 chunk +3 lines, -0 lines 0 comments
M src/mips/simulator-mips.cc View 9 chunks +489 lines, -34 lines 0 comments
M src/mips64/assembler-mips64.h View 2 chunks +20 lines, -0 lines 0 comments
M src/mips64/assembler-mips64.cc View 13 chunks +151 lines, -42 lines 0 comments
M src/mips64/constants-mips64.h View 4 chunks +19 lines, -4 lines 0 comments
M src/mips64/disasm-mips64.cc View 2 chunks +22 lines, -0 lines 0 comments
M src/mips64/simulator-mips64.h View 1 chunk +4 lines, -1 line 0 comments
M src/mips64/simulator-mips64.cc View 9 chunks +423 lines, -14 lines 0 comments
M test/cctest/test-assembler-mips.cc View 13 chunks +1371 lines, -56 lines 0 comments
M test/cctest/test-assembler-mips64.cc View 16 chunks +1332 lines, -140 lines 0 comments
M test/cctest/test-disasm-mips.cc View 1 chunk +78 lines, -5 lines 0 comments
M test/cctest/test-disasm-mips64.cc View 1 chunk +76 lines, -2 lines 0 comments

Messages

Total messages: 6 (2 generated)
dusmil.imgtec
lgtm.
5 years, 7 months ago (2015-05-19 09:59:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147493002/20001
5 years, 7 months ago (2015-05-19 10:08:56 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-19 10:35:29 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 10:35:44 UTC) #6
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0f93a456ec8b17eeb47154842c6a888cebd53bf7
Cr-Commit-Position: refs/heads/master@{#28472}

Powered by Google App Engine