Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1147483003: [Password manager tests automation] Fix "No such frame" error. (Closed)

Created:
5 years, 7 months ago by melandory
Modified:
5 years, 7 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password manager tests automation] Fix "No such frame" error. In some cases selenium are unable to select frame, which give an exception and prevents test running. Fix this by explicitly navigating to desired frame. BUG=369521 R=vabr@chromium.org Committed: https://crrev.com/a57762c31ca0760329bbe006115fa5ef3a639e68 Cr-Commit-Position: refs/heads/master@{#330491}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M components/test/data/password_manager/automated_tests/environment.py View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
melandory
Hi Vaclav, review this CL, please. Unfortunately, I was unable to discover why switch_to_frame fails.
5 years, 7 months ago (2015-05-18 14:09:04 UTC) #1
vabr (Chromium)
LGTM! I suspect this might be the issue of the settings page loading too slowly. ...
5 years, 7 months ago (2015-05-18 15:34:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147483003/1
5 years, 7 months ago (2015-05-19 07:52:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 07:55:57 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 07:56:58 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a57762c31ca0760329bbe006115fa5ef3a639e68
Cr-Commit-Position: refs/heads/master@{#330491}

Powered by Google App Engine
This is Rietveld 408576698