Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 1147463003: Linux sandbox: support build configuration without base test framework (Closed)

Created:
5 years, 7 months ago by jln (very slow on Chromium)
Modified:
5 years, 7 months ago
Reviewers:
mdempsky
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux sandbox: support build configuration without base test framework Support building sandbox_linux_unittests without requiring the base test framework. It was already supported for Android, but make it a more generic option. BUG=488310 Committed: https://crrev.com/01954fd5da6359cab9d588caf575e68ca229719f Cr-Commit-Position: refs/heads/master@{#330051}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -14 lines) Patch
M sandbox/linux/BUILD.gn View 1 4 chunks +17 lines, -4 lines 0 comments Download
M sandbox/linux/sandbox_linux.gypi View 1 2 chunks +10 lines, -0 lines 0 comments Download
M sandbox/linux/sandbox_linux_test_sources.gypi View 2 chunks +15 lines, -2 lines 0 comments Download
M sandbox/linux/tests/main.cc View 1 2 4 chunks +8 lines, -6 lines 0 comments Download
M sandbox/linux/tests/unit_tests.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jln (very slow on Chromium)
PTAL!
5 years, 7 months ago (2015-05-15 02:04:29 UTC) #2
mdempsky
lgtm https://codereview.chromium.org/1147463003/diff/20001/sandbox/linux/tests/unit_tests.cc File sandbox/linux/tests/unit_tests.cc (right): https://codereview.chromium.org/1147463003/diff/20001/sandbox/linux/tests/unit_tests.cc#newcode289 sandbox/linux/tests/unit_tests.cc:289: // This hack is required when a signaal ...
5 years, 7 months ago (2015-05-15 02:33:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147463003/40001
5 years, 7 months ago (2015-05-15 05:33:03 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-15 06:19:45 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 06:20:28 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/01954fd5da6359cab9d588caf575e68ca229719f
Cr-Commit-Position: refs/heads/master@{#330051}

Powered by Google App Engine
This is Rietveld 408576698