Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 1147453003: Measure inappropriate_fallback alerts from Google. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fallback-type
Patch Set: revise various wordings Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « net/http/http_network_transaction.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index a7019e3dca6785a46bd0e7747a3d286040faaf76..495a44c4f10f1a1989078dcc435d3fce186ed596 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -19457,6 +19457,17 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
+<histogram name="Net.GoogleConnectionInappropriateFallback"
+ enum="BooleanInappropriateFallback">
+ <owner>davidben@chromium.org</owner>
+ <summary>
+ Records a sample for each HTTPS request to a Google server that either
+ succeeded or received an inappropriate_fallback alert. This is used to
+ estimate how frequently the fallback is used to recover from a spurious
+ network failure.
+ </summary>
+</histogram>
+
<histogram name="Net.GoogleConnectionUsedSSLVersionFallback"
enum="FallbackSSLVersion">
<obsolete>
@@ -19477,8 +19488,8 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<summary>
For each successful HTTPS request to a Google server, whether it used the
SSL version fallback. The value indicates the SSL version the request fell
- back on. Since Google servers support TLS 1.2, any fallback is an indication
- of network middleware problems.
+ back on. Since Google servers support TLS 1.2 and FALLBACK_SCSV, any
+ fallback is an indication of a broken local SSL MITM proxy.
</summary>
</histogram>
@@ -48265,6 +48276,11 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<int value="1" label="Ignored"/>
</enum>
+<enum name="BooleanInappropriateFallback" type="int">
+ <int value="0" label="Handshake successful"/>
+ <int value="1" label="inappropriate_fallback alert"/>
Ilya Sherman 2015/05/18 18:55:34 nit: Why not "Inappropriate fallback alert"? (Whi
davidben 2015/05/18 19:09:09 Alerts are a type of error in the TLS protocol and
+</enum>
+
<enum name="BooleanIsMobileOptimized" type="int">
<int value="0" label="Not mobile optimized web page"/>
<int value="1" label="Mobile optimized web page"/>
« no previous file with comments | « net/http/http_network_transaction.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698