Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: webkit/plugins/ppapi/ppb_video_decoder_impl.cc

Issue 11474040: Fix some types at the IPC layer. Sizes should be unsigned. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ppapi/proxy/ppb_video_decoder_proxy.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "webkit/plugins/ppapi/ppb_video_decoder_impl.h" 5 #include "webkit/plugins/ppapi/ppb_video_decoder_impl.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/message_loop.h" 10 #include "base/message_loop.h"
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 return PP_ERROR_BADRESOURCE; 135 return PP_ERROR_BADRESOURCE;
136 136
137 EnterResourceNoLock<PPB_Buffer_API> enter(bitstream_buffer->data, true); 137 EnterResourceNoLock<PPB_Buffer_API> enter(bitstream_buffer->data, true);
138 if (enter.failed()) 138 if (enter.failed())
139 return PP_ERROR_FAILED; 139 return PP_ERROR_FAILED;
140 140
141 PPB_Buffer_Impl* buffer = static_cast<PPB_Buffer_Impl*>(enter.object()); 141 PPB_Buffer_Impl* buffer = static_cast<PPB_Buffer_Impl*>(enter.object());
142 media::BitstreamBuffer decode_buffer( 142 media::BitstreamBuffer decode_buffer(
143 bitstream_buffer->id, 143 bitstream_buffer->id,
144 buffer->shared_memory()->handle(), 144 buffer->shared_memory()->handle(),
145 static_cast<size_t>(bitstream_buffer->size)); 145 bitstream_buffer->size);
146 if (!SetBitstreamBufferCallback(bitstream_buffer->id, callback)) 146 if (!SetBitstreamBufferCallback(bitstream_buffer->id, callback))
147 return PP_ERROR_BADARGUMENT; 147 return PP_ERROR_BADARGUMENT;
148 148
149 FlushCommandBuffer(); 149 FlushCommandBuffer();
150 platform_video_decoder_->Decode(decode_buffer); 150 platform_video_decoder_->Decode(decode_buffer);
151 return PP_OK_COMPLETIONPENDING; 151 return PP_OK_COMPLETIONPENDING;
152 } 152 }
153 153
154 void PPB_VideoDecoder_Impl::AssignPictureBuffers( 154 void PPB_VideoDecoder_Impl::AssignPictureBuffers(
155 uint32_t no_of_buffers, 155 uint32_t no_of_buffers,
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 void PPB_VideoDecoder_Impl::NotifyFlushDone() { 267 void PPB_VideoDecoder_Impl::NotifyFlushDone() {
268 RunFlushCallback(PP_OK); 268 RunFlushCallback(PP_OK);
269 } 269 }
270 270
271 void PPB_VideoDecoder_Impl::NotifyInitializeDone() { 271 void PPB_VideoDecoder_Impl::NotifyInitializeDone() {
272 NOTREACHED() << "PlatformVideoDecoder::Initialize() is synchronous!"; 272 NOTREACHED() << "PlatformVideoDecoder::Initialize() is synchronous!";
273 } 273 }
274 274
275 } // namespace ppapi 275 } // namespace ppapi
276 } // namespace webkit 276 } // namespace webkit
OLDNEW
« no previous file with comments | « ppapi/proxy/ppb_video_decoder_proxy.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698