Remove initial_sync_ended bits

sync/internal_api/public/sessions/sync_session_snapshot.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SYNC_INTERNAL_API_PUBLIC_SESSIONS_SYNC_SESSION_SNAPSHOT_H_
 #define SYNC_INTERNAL_API_PUBLIC_SESSIONS_SYNC_SESSION_SNAPSHOT_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 13 matching lines @@
 // An immutable snapshot of state from a SyncSession.  Convenient to use as
 // part of notifications as it is inherently thread-safe.
 // TODO(zea): if copying this all over the place starts getting expensive,
 // consider passing around immutable references instead of values.
 // Default copy and assign welcome.
 class SyncSessionSnapshot {
  public:
   SyncSessionSnapshot();
   SyncSessionSnapshot(
       const ModelNeutralState& model_neutral_state,
-      bool is_share_usable,

[Nicolas Zea, 2012/12/10 22:50:38]

why is is_share_usable being removed as well? (I'll be honest, I don't even know
what it's for)

[tim (not reviewing), 2012/12/10 23:05:36]

It used to denote "initial sync ended for all datatypes", and we wouldn't let
anything interact with the sync engine until that condition was met.  The
concept doesn't really make sense anymore though and AFAICT it's not used in any
important way. I think AllStatus uses it, but at the time is_share_usable was
relevant AllStatus wasn't, so I doubt it's doing anything important.

-      ModelTypeSet initial_sync_ended,
       const ProgressMarkerMap& download_progress_markers,
       bool is_silenced,
       int num_encryption_conflicts,
       int num_hierarchy_conflicts,
       int num_server_conflicts,
       const SyncSourceInfo& source,
       const std::vector<SyncSourceInfo>& debug_info_sources_list,
       bool notifications_enabled,
       size_t num_entries,
       base::Time sync_start_time,
       const std::vector<int>& num_entries_by_type,
       const std::vector<int>& num_to_delete_entries_by_type);
   ~SyncSessionSnapshot();
 
   // Caller takes ownership of the returned dictionary.
   base::DictionaryValue* ToValue() const;
 
   std::string ToString() const;
 
   ModelNeutralState model_neutral_state() const {
     return model_neutral_state_;
   }
   int64 num_server_changes_remaining() const;
-  bool is_share_usable() const;
-  ModelTypeSet initial_sync_ended() const;
   const ProgressMarkerMap& download_progress_markers() const;
   bool is_silenced() const;
   int num_encryption_conflicts() const;
   int num_hierarchy_conflicts() const;
   int num_server_conflicts() const;
   SyncSourceInfo source() const;
   const std::vector<SyncSourceInfo>& debug_info_sources_list() const;
   bool notifications_enabled() const;
   size_t num_entries() const;
   base::Time sync_start_time() const;
   const std::vector<int>& num_entries_by_type() const;
   const std::vector<int>& num_to_delete_entries_by_type() const;
 
   // Set iff this snapshot was not built using the default constructor.
   bool is_initialized() const;
 
  private:
   ModelNeutralState model_neutral_state_;
-  bool is_share_usable_;
-  ModelTypeSet initial_sync_ended_;
   ProgressMarkerMap download_progress_markers_;
   bool is_silenced_;
   int num_encryption_conflicts_;
   int num_hierarchy_conflicts_;
   int num_server_conflicts_;
   SyncSourceInfo source_;
   std::vector<SyncSourceInfo> debug_info_sources_list_;
   bool notifications_enabled_;
   size_t num_entries_;
   base::Time sync_start_time_;
 
   std::vector<int> num_entries_by_type_;
   std::vector<int> num_to_delete_entries_by_type_;
 
   bool is_initialized_;
 };
 
 }  // namespace sessions
 }  // namespace syncer
 
 #endif  // SYNC_INTERNAL_API_PUBLIC_SESSIONS_SYNC_SESSION_SNAPSHOT_H_