Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1147383002: Revert of First pass BackgroundTracingManager. (Closed)

Created:
5 years, 7 months ago by shatch
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of First pass BackgroundTracingManager. (patchset #15 id:450001 of https://codereview.chromium.org/1089253003/) Reason for revert: Failed TSan Tests. http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20TSan%20Tests/builds/4795 Original issue's description: > Skeleton for BackgroundTracingManager. > > This version mostly just directs the TracingController using the specified BackgroundTracingConfig and pushes the compressed trace out to the BackgroundTracingUploadSink. > > Specifically, we implement the PREEMPTIVE_TRACING_MODE for the rule MONITOR_AND_DUMP_WHEN_TRIGGER_NAMED, which should allow us to get an experiment going on desktop with a simple trigger and upload. > > We can then follow up with additional CL's implementing the rest of the functionality from the clientside doc below. > > Needs to land first: https://codereview.chromium.org/1088673003/ > > Slow Reports Clientside: https://docs.google.com/document/d/1qZmXmodxOKmsTRO27z2WlH2h9Kpf-kjV-k-1pJIogIE/edit?pli=1 > > go/slow-reports > > Committed: https://crrev.com/c9cd43c8963301a6b1ebfb74c4eb03b8c733e9f9 > Cr-Commit-Position: refs/heads/master@{#330942} TBR=dsinclair@chromium.org,nduca@chromium.org,oysteine@chromium.org,sievers@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/aefbdd17287f7591cca603938629f2d55cbe9fda Cr-Commit-Position: refs/heads/master@{#330949}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1010 lines) Patch
D content/browser/tracing/background_tracing_manager_browsertest.cc View 1 chunk +0 lines, -338 lines 0 comments Download
D content/browser/tracing/background_tracing_manager_impl.h View 1 chunk +0 lines, -85 lines 0 comments Download
D content/browser/tracing/background_tracing_manager_impl.cc View 1 chunk +0 lines, -312 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +0 lines, -9 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D content/public/browser/background_tracing_config.h View 1 chunk +0 lines, -43 lines 0 comments Download
D content/public/browser/background_tracing_config.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D content/public/browser/background_tracing_manager.h View 1 chunk +0 lines, -94 lines 0 comments Download
D content/public/browser/background_tracing_preemptive_config.h View 1 chunk +0 lines, -45 lines 0 comments Download
D content/public/browser/background_tracing_preemptive_config.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D content/public/browser/background_tracing_reactive_config.h View 1 chunk +0 lines, -35 lines 0 comments Download
D content/public/browser/background_tracing_reactive_config.cc View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
shatch
Created Revert of First pass BackgroundTracingManager.
5 years, 7 months ago (2015-05-21 17:53:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147383002/1
5 years, 7 months ago (2015-05-21 17:54:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 17:55:56 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 17:56:33 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aefbdd17287f7591cca603938629f2d55cbe9fda
Cr-Commit-Position: refs/heads/master@{#330949}

Powered by Google App Engine
This is Rietveld 408576698