LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer-expected.html - Issue 1147363009: Use replacedContentBox for LayoutHTMLCanvas when deciding PaintLayer's contentBox.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer-expected.html

Issue 1147363009: Use replacedContentBox for LayoutHTMLCanvas when deciding PaintLayer's contentBox. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer.html ('K') | « LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer.html ('k') | Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 canvas {

	4 border: black 1px solid;

	5 background-color: gray;

	6 width: 200px;

	7 height: 200px;

	8 object-fit: contain;
	Justin Novosad 2015/06/09 19:24:10 Test would be more effective if the reference did Test would be more effective if the reference did not use object-fit. Just a 200x200 canvas with the right rect coords will do. Orange rect is (50, 0, 100, 200), green rect is (75, 75, 50, 50). This way the test can detect more types of bugs, like a bad offset. changseok 2015/06/11 05:46:47 I updated the test. Please check it again if it ma Show quoted text On 2015/06/09 19:24:10, Justin Novosad wrote: > Test would be more effective if the reference did not use object-fit. Just a > 200x200 canvas with the right rect coords will do. Orange rect is (50, 0, 100, > 200), green rect is (75, 75, 50, 50). This way the test can detect more types of > bugs, like a bad offset. I updated the test. Please check it again if it makes you happy. =)
	9 }

	10 </style>

	11 <p>Test passes if a green square inside a orange rectanlge is shown up without a distortion.

	12 <div>

	13 <canvas width="100" height="200"></canvas>

	14 </div>

	15 <script>

	16 function paintCanvas(canvas)

	17 {

	18 var ctx = canvas.getContext('2d');

	19 ctx.fillStyle = 'orange';

	20 ctx.fillRect(0, 0, canvas.width, canvas.height);

	21

	22 ctx.beginPath();
	Justin Novosad 2015/06/09 19:20:43 Not necessary Not necessary changseok 2015/06/11 05:46:46 Done. Show quoted text On 2015/06/09 19:20:43, Justin Novosad wrote: > Not necessary Done.
	23 ctx.fillStyle = 'green';

	24 var squarWidth = canvas.width / 2;

	25 var squarHalfWidth = squarWidth / 2;

	26 ctx.fillRect(canvas.width / 2 - squarHalfWidth, canvas.height / 2 - squarHalfW idth , squarWidth, squarWidth);

	27 ctx.fill();
	Justin Novosad 2015/06/09 19:20:43 not necessary not necessary changseok 2015/06/11 05:46:47 Done. Show quoted text On 2015/06/09 19:20:43, Justin Novosad wrote: > not necessary Done.
	28 }

	29

	30 paintCanvas(document.querySelector('canvas'));

	31 </script>

OLD	NEW