Use replacedContentBox for LayoutHTMLCanvas when deciding PaintLayer's contentBox.

Use replacedContentBox for LayoutHTMLCanvas when deciding PaintLayer's contentBox.

If a canvas size goes over the minimunAccelerated2dCanvasSize we set in Settings.in,
the canvas image is rendered in a paint layer. The problem is here the paint layer's
geomery is incorrect since a wrong content bounding size is used for the canvas.
LayoutHTMLCanvas is a kind of LayoutReplaced objects. Its geometry could be changed
after replacing an original content with an actual one or updating styles like object-fit.
Using LayoutBox::contentBox() for LayoutHTMLCanvas is such a carelessness. We can fix this
by using replacedContentBox() rather than using just contentBox() for a canvas.

BUG=467409
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197160

[changseok, 2015-06-08 08:14:04]

shivamidow@gmail.com changed reviewers:
+ chrishtr@chromium.org, eae@chromium.org, leviw@chromium.org,
mstensho@opera.com, timloh@chromium.org

[changseok, 2015-06-08 08:14:04]

Please have a look

[chrishtr, 2015-06-09 18:41:52]

chrishtr@chromium.org changed reviewers:
+ junov@chromium.org

[Justin Novosad, 2015-06-09 19:20:44]

https://codereview.chromium.org/1147363009/diff/1/LayoutTests/compositing/can...
File
LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer-expected.html
(right):

https://codereview.chromium.org/1147363009/diff/1/LayoutTests/compositing/can...
LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer-expected.html:22:
ctx.beginPath();
Not necessary

https://codereview.chromium.org/1147363009/diff/1/LayoutTests/compositing/can...
LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer-expected.html:27:
ctx.fill();
not necessary

https://codereview.chromium.org/1147363009/diff/1/LayoutTests/compositing/can...
File
LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer.html
(right):

https://codereview.chromium.org/1147363009/diff/1/LayoutTests/compositing/can...
LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer.html:22:
ctx.beginPath();
This line is not needed IMHO

https://codereview.chromium.org/1147363009/diff/1/LayoutTests/compositing/can...
LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer.html:27:
ctx.fill();
This one too.

[Justin Novosad, 2015-06-09 19:24:10]

https://codereview.chromium.org/1147363009/diff/1/LayoutTests/compositing/can...
File
LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer-expected.html
(right):

https://codereview.chromium.org/1147363009/diff/1/LayoutTests/compositing/can...
LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer-expected.html:8:
object-fit: contain;
Test would be more effective if the reference did not use object-fit.  Just a
200x200 canvas with the right rect coords will do. Orange rect is (50, 0, 100,
200), green rect is (75, 75, 50, 50). This way the test can detect more types of
bugs, like a bad offset.

[changseok, 2015-06-11 05:46:47]

Thanks for your review.

https://codereview.chromium.org/1147363009/diff/1/LayoutTests/compositing/can...
File
LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer-expected.html
(right):

https://codereview.chromium.org/1147363009/diff/1/LayoutTests/compositing/can...
LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer-expected.html:8:
object-fit: contain;
On 2015/06/09 19:24:10, Justin Novosad wrote:
> Test would be more effective if the reference did not use object-fit.  Just a
> 200x200 canvas with the right rect coords will do. Orange rect is (50, 0, 100,
> 200), green rect is (75, 75, 50, 50). This way the test can detect more types
of
> bugs, like a bad offset.

I updated the test. Please check it again if it makes you happy. =)

https://codereview.chromium.org/1147363009/diff/1/LayoutTests/compositing/can...
LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer-expected.html:22:
ctx.beginPath();
On 2015/06/09 19:20:43, Justin Novosad wrote:
> Not necessary

Done.

https://codereview.chromium.org/1147363009/diff/1/LayoutTests/compositing/can...
LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer-expected.html:27:
ctx.fill();
On 2015/06/09 19:20:43, Justin Novosad wrote:
> not necessary

Done.

https://codereview.chromium.org/1147363009/diff/1/LayoutTests/compositing/can...
File
LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer.html
(right):

https://codereview.chromium.org/1147363009/diff/1/LayoutTests/compositing/can...
LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer.html:22:
ctx.beginPath();
On 2015/06/09 19:20:44, Justin Novosad wrote:
> This line is not needed IMHO

Removed.

https://codereview.chromium.org/1147363009/diff/1/LayoutTests/compositing/can...
LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer.html:27:
ctx.fill();
On 2015/06/09 19:20:44, Justin Novosad wrote:
> This one too.

Done.

[changseok, 2015-06-12 20:56:30]

Any other comment?

[Justin Novosad, 2015-06-15 13:56:24]

On 2015/06/12 20:56:30, changseok wrote:
> Any other comment?

lgtm

[changseok, 2015-06-16 02:47:25]

The CQ bit was checked by shivamidow@gmail.com

[commit-bot: I haz the power, 2015-06-16 02:47:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1147363009/20001

[commit-bot: I haz the power, 2015-06-16 07:06:59]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197160