chrome/browser/ui/elide_url.h - Issue 1147363005: Create FormatUrlForSecurityDisplay helper function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/elide_url.h

Issue 1147363005: Create FormatUrlForSecurityDisplay helper function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename to FormatUrlForSecurityDisplay. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/content_settings/content_setting_bubble_model.cc ('k') | chrome/browser/ui/elide_url.cc » ('j') | chrome/browser/ui/elide_url.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/elide_url.h

diff --git a/chrome/browser/ui/elide_url.h b/chrome/browser/ui/elide_url.h

index bd5321a633fbfb5513374903427ca6353be26ada..0d7e831316002069b937273d93ec71c5e20456bc 100644

--- a/chrome/browser/ui/elide_url.h

+++ b/chrome/browser/ui/elide_url.h

@@ -45,4 +45,16 @@ base::string16 ElideHost(const GURL& host_url,

const gfx::FontList& font_list,

float available_pixel_width);

+// This is a convenience function for formatting a URL in a concise and

+// human-friendly way, to help users make security-related decisions (or in

+// other circumstances when people need to distinguish sites, origins, or

+// otherwise-simplified URLs from each other).

+//

+// - Omits the path for standard schemes, excepting file and filesystem.

+// - Omits the port if it is the default for the scheme.

+//

+// Do not use this for URLs which will be parsed or sent to other applications.

+base::string16 FormatUrlForSecurityDisplay(const GURL& origin,

msw 2015/06/02 23:45:16 nit: maybe replace security for "simple" or "conci

palmer 2015/06/03 01:01:46 So far I think security UX is the main driver for

+ const std::string& languages);

#endif // CHROME_BROWSER_UI_ELIDE_URL_H_

« no previous file with comments | « chrome/browser/ui/content_settings/content_setting_bubble_model.cc ('k') | chrome/browser/ui/elide_url.cc » ('j') | chrome/browser/ui/elide_url.cc » ('J')