Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1147363004: [AppRemoting] Improve Auto-reconnect. (Closed)

Created:
5 years, 6 months ago by kelvinp
Modified:
5 years, 6 months ago
Reviewers:
Jamie, Wez
CC:
chromium-reviews, dcheng, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This CL addresses wez and Jamie's feedback on the reliability of the reconnect due to the unreliability of navigator.onLine. Summary of changes: 1. If navigator.onLine is true when the connection is dropped auto-reconnect without showing the connection dropped dialog otherwise show connection dropped dialog and reconnect when navigation.onLine becomes true 2. The unreliability of navigator.onLine is mitigated by a new class remoting.AutoRetyXHR, which will retry an XHR request if the request fails due to network error for every 2 seconds until the max retry attempts is reached. Committed: https://crrev.com/a6852cc61cf2e5c487355d9110e4192ff9c1e536 Cr-Commit-Position: refs/heads/master@{#332248}

Patch Set 1 : #

Total comments: 16

Patch Set 2 : Reviewer's feedback #

Total comments: 3

Patch Set 3 : Ready for check-in #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -59 lines) Patch
M remoting/resources/remoting_strings.grd View 1 chunk +1 line, -4 lines 0 comments Download
M remoting/webapp/app_remoting/js/app_remoting_activity.js View 1 2 3 3 chunks +21 lines, -8 lines 0 comments Download
M remoting/webapp/base/html/connection_dropped_dialog.html View 1 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/webapp/base/js/base.js View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M remoting/webapp/base/js/connection_dropped_dialog.js View 1 2 3 4 chunks +8 lines, -44 lines 0 comments Download
M remoting/webapp/base/js/xhr.js View 1 2 3 1 chunk +64 lines, -0 lines 0 comments Download
M remoting/webapp/base/js/xhr_unittest.js View 1 2 2 chunks +132 lines, -0 lines 0 comments Download
M remoting/webapp/js_proto/sinon_proto.js View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
kelvinp
PTAL
5 years, 6 months ago (2015-05-28 23:01:45 UTC) #3
Jamie
https://codereview.chromium.org/1147363004/diff/20001/remoting/webapp/app_remoting/js/app_remoting_activity.js File remoting/webapp/app_remoting/js/app_remoting_activity.js (right): https://codereview.chromium.org/1147363004/diff/20001/remoting/webapp/app_remoting/js/app_remoting_activity.js#newcode89 remoting/webapp/app_remoting/js/app_remoting_activity.js:89: var retryAttempts = 7; Why 7? It seems like ...
5 years, 6 months ago (2015-05-29 17:52:52 UTC) #4
Wez
https://codereview.chromium.org/1147363004/diff/20001/remoting/webapp/app_remoting/js/app_remoting_activity.js File remoting/webapp/app_remoting/js/app_remoting_activity.js (right): https://codereview.chromium.org/1147363004/diff/20001/remoting/webapp/app_remoting/js/app_remoting_activity.js#newcode90 remoting/webapp/app_remoting/js/app_remoting_activity.js:90: return new remoting.XhrAutoRetry({ This is a horrible hack around ...
5 years, 6 months ago (2015-05-29 18:09:20 UTC) #5
kelvinp
PTAL. https://codereview.chromium.org/1147363004/diff/20001/remoting/webapp/app_remoting/js/app_remoting_activity.js File remoting/webapp/app_remoting/js/app_remoting_activity.js (right): https://codereview.chromium.org/1147363004/diff/20001/remoting/webapp/app_remoting/js/app_remoting_activity.js#newcode89 remoting/webapp/app_remoting/js/app_remoting_activity.js:89: var retryAttempts = 7; On 2015/05/29 17:52:52, Jamie ...
5 years, 6 months ago (2015-05-30 00:16:17 UTC) #7
Jamie
lgtm https://codereview.chromium.org/1147363004/diff/60001/remoting/webapp/base/js/xhr.js File remoting/webapp/base/js/xhr.js (right): https://codereview.chromium.org/1147363004/diff/60001/remoting/webapp/base/js/xhr.js#newcode352 remoting/webapp/base/js/xhr.js:352: * HTTP status would be 0 when the ...
5 years, 6 months ago (2015-05-30 00:38:34 UTC) #8
kelvinp
FYI
5 years, 6 months ago (2015-06-01 17:16:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147363004/80001
5 years, 6 months ago (2015-06-01 17:16:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147363004/100001
5 years, 6 months ago (2015-06-01 18:26:40 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:100001)
5 years, 6 months ago (2015-06-01 19:55:12 UTC) #17
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 19:56:03 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a6852cc61cf2e5c487355d9110e4192ff9c1e536
Cr-Commit-Position: refs/heads/master@{#332248}

Powered by Google App Engine
This is Rietveld 408576698