Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1147353007: safe_browsing_blocking_page_test.cc: Use mock URLRequest jobs instead of SpawnedTestServer. (Closed)

Created:
5 years, 6 months ago by mattm
Modified:
5 years, 6 months ago
Reviewers:
mmenke
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@sb-test-server2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

safe_browsing_blocking_page_test.cc: Use mock URLRequest jobs instead of SpawnedTestServer. BUG=493800 Committed: https://crrev.com/dbdcceb6f26df6577a8b423920fc0fa1ec1749ee Cr-Commit-Position: refs/heads/master@{#333123}

Patch Set 1 #

Total comments: 3

Patch Set 2 : review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -31 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 1 9 chunks +19 lines, -19 lines 0 comments Download
M chrome/test/data/safe_browsing/iframe_redirect_malware.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/safe_browsing/interstitial_cancel.html View 2 chunks +2 lines, -11 lines 0 comments Download
A + chrome/test/data/safe_browsing/redirect_to_malware.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/safe_browsing/redirect_to_malware.html.mock-http-headers View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mattm
(depends on https://codereview.chromium.org/1143053006/) https://codereview.chromium.org/1147353007/diff/1/chrome/test/data/safe_browsing/interstitial_cancel.html File chrome/test/data/safe_browsing/interstitial_cancel.html (left): https://codereview.chromium.org/1147353007/diff/1/chrome/test/data/safe_browsing/interstitial_cancel.html#oldcode10 chrome/test/data/safe_browsing/interstitial_cancel.html:10: function openMalware() This is apparently just ...
5 years, 6 months ago (2015-06-05 01:23:41 UTC) #2
mmenke
LGTM https://codereview.chromium.org/1147353007/diff/1/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc File chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc (right): https://codereview.chromium.org/1147353007/diff/1/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc#newcode503 chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc:503: net::URLRequestMockHTTPJob::GetMockUrl("safe_browsing/malware.html"); kMalwarePage?
5 years, 6 months ago (2015-06-05 15:20:29 UTC) #3
mattm
https://codereview.chromium.org/1147353007/diff/1/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc File chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc (right): https://codereview.chromium.org/1147353007/diff/1/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc#newcode503 chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc:503: net::URLRequestMockHTTPJob::GetMockUrl("safe_browsing/malware.html"); On 2015/06/05 15:20:28, mmenke wrote: > kMalwarePage? Done.
5 years, 6 months ago (2015-06-05 19:37:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147353007/20001
5 years, 6 months ago (2015-06-05 19:39:21 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-05 20:47:05 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 20:47:53 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/dbdcceb6f26df6577a8b423920fc0fa1ec1749ee
Cr-Commit-Position: refs/heads/master@{#333123}

Powered by Google App Engine
This is Rietveld 408576698