Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Unified Diff: tools/nanobench_flags.py

Issue 1147333002: Disable nanobench options for iOS (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/nanobench_flags.py
diff --git a/tools/nanobench_flags.py b/tools/nanobench_flags.py
index fb6d86363a8f570be3f9c691cde2e739039f0171..b96761c6eeddd00cd4d355dc335f91652f043f7f 100755
--- a/tools/nanobench_flags.py
+++ b/tools/nanobench_flags.py
@@ -31,6 +31,9 @@ def get_args(bot):
args.extend(['--scales', '1.0', '1.1'])
+ if 'iOS' in bot:
+ args.extend(['--skps', 'ignore_skps'])
+
config = ['565', '8888', 'gpu', 'nonrendering', 'angle', 'hwui']
# The S4 crashes and the NP produces a long error stream when we run with
# MSAA.
@@ -65,6 +68,12 @@ def get_args(bot):
if 'NexusPlayer' in bot:
match.append('~desk_unicodetable')
+ if 'iOS' in bot:
+ match.append('~blurroundrect')
+ match.append('~patch_grid') # skia:2847
+ match.append('~desk_carsvg')
+ match.append('~keymobi')
+
if match:
args.append('--match')
args.extend(match)
@@ -81,6 +90,7 @@ def self_test():
'Perf-Android-GCC-NexusPlayer-GPU-PowerVR-x86-Release',
'Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind',
'Test-Win7-MSVC-ShuttleA-GPU-HD2000-x86-Debug-ANGLE',
+ 'Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug',
]
cov = coverage.coverage()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698