Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1147333002: Disable nanobench options for iOS (Closed)

Created:
5 years, 7 months ago by stephana
Modified:
5 years, 7 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Temporarily disable nanobench to see what else is in the way of the bots going green. NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/18b72db6aa4033d1b4e5416aa0a613140a370c12

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M tools/nanobench_flags.py View 1 2 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
stephana
5 years, 7 months ago (2015-05-21 19:30:24 UTC) #2
stephana
On 2015/05/21 19:30:24, stephana wrote: This should turn the Debug bot green. I am still ...
5 years, 7 months ago (2015-05-21 19:30:53 UTC) #3
borenet
LGTM
5 years, 7 months ago (2015-05-21 19:35:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147333002/60001
5 years, 7 months ago (2015-05-21 20:38:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/53)
5 years, 7 months ago (2015-05-21 20:39:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147333002/80001
5 years, 7 months ago (2015-05-21 20:48:28 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/55)
5 years, 7 months ago (2015-05-21 20:49:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147333002/80001
5 years, 7 months ago (2015-05-21 20:58:53 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 20:59:41 UTC) #16
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/18b72db6aa4033d1b4e5416aa0a613140a370c12

Powered by Google App Engine
This is Rietveld 408576698